Initialize input v2 API #19158
Merged
Initialize input v2 API #19158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
review
refactoring
Filebeat
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andresrc
added
[zube]: Inbox
[zube]: In Review
Team:Integrations
kvch
reviewed
Jun 16, 2020
added 2 commits
June 17, 2020 13:44
This change adds the package filebeat/input/v2. It introduces the interfaces for the v2 input API only. The integration with filebat, actual InputManagers and input implementations will follow.
kvch
reviewed
Jun 17, 2020
kvch
reviewed
Jun 17, 2020
kvch
reviewed
Jun 17, 2020
kvch
approved these changes
Jun 17, 2020
kvch
approved these changes
Jun 18, 2020
3 tasks
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jul 6, 2020
This change adds the package filebeat/input/v2. It introduces the interfaces for the v2 input API only. The integration with filebat, actual InputManagers and input implementations will follow. This is the first PR introducing the new API. The current state of the full implementation can be seen [here](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2) and [sample inputs based on the new API](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/features/input). The full list of changes will include: - Introduce v2 API interfaces - Introduce [compatibility layer](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/compat) to integrate API with existing functionality - Introduce helpers for writing [stateless](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/input/v2/input-stateless/stateless.go) inputs. - Introduce helpers for writing [inputs that store a state](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/input-cursor) between restarts. - Integrate new API with [existing inputs and modules](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/beater/filebeat.go#L301) in filebeat. This PR only introduces the v2 API interfaces. (cherry picked from commit 27e28c8)
urso
pushed a commit
that referenced
this pull request
Jul 7, 2020
This change adds the package filebeat/input/v2. It introduces the interfaces for the v2 input API only. The integration with filebat, actual InputManagers and input implementations will follow. This is the first PR introducing the new API. The current state of the full implementation can be seen [here](urso/beats:filebeat/input/v2@fb-input-v2-combined) and [sample inputs based on the new API](urso/beats:filebeat/features/input@fb-input-v2-combined). The full list of changes will include: - Introduce v2 API interfaces - Introduce [compatibility layer](urso/beats:filebeat/input/v2/compat@fb-input-v2-combined) to integrate API with existing functionality - Introduce helpers for writing [stateless](urso/beats:filebeat/input/v2/input-stateless/stateless.go@fb-input-v2-combined) inputs. - Introduce helpers for writing [inputs that store a state](urso/beats:filebeat/input/v2/input-cursor@fb-input-v2-combined) between restarts. - Integrate new API with [existing inputs and modules](urso/beats:filebeat/beater/filebeat.go@fb-input-v2-combined#L301) in filebeat. This PR only introduces the v2 API interfaces. (cherry picked from commit 27e28c8)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
This change adds the package filebeat/input/v2. It introduces the interfaces for the v2 input API only. The integration with filebat, actual InputManagers and input implementations will follow. This is the first PR introducing the new API. The current state of the full implementation can be seen [here](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2) and [sample inputs based on the new API](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/features/input). The full list of changes will include: - Introduce v2 API interfaces - Introduce [compatibility layer](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/compat) to integrate API with existing functionality - Introduce helpers for writing [stateless](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/input/v2/input-stateless/stateless.go) inputs. - Introduce helpers for writing [inputs that store a state](https://github.com/urso/beats/tree/fb-input-v2-combined/filebeat/input/v2/input-cursor) between restarts. - Integrate new API with [existing inputs and modules](https://github.com/urso/beats/blob/fb-input-v2-combined/filebeat/beater/filebeat.go#L301) in filebeat. This PR only introduces the v2 API interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds the package filebeat/input/v2. It introduces the
interfaces for the v2 input API only. The integration with filebat,
actual InputManagers and input implementations will follow.
This is the first PR introducing the new API. The current state of the full implementation can be seen here and sample inputs based on the new API.
The full list of changes will include:
This PR only introduces the v2 API interfaces.
Why is it important?
Init API for new style filebeat inputs.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues