Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #19149 to 7.x: [Filebeat] Fix Cisco ASA dissect pattern for 313008 & 313009 #19235

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Cherry-pick #19149 to 7.x: [Filebeat] Fix Cisco ASA dissect pattern for 313008 & 313009 #19235

merged 3 commits into from
Jul 13, 2020

Conversation

adriansr
Copy link
Contributor

Cherry-pick of PR #19149 to 7.x branch. Original message:

What does this PR do?

Corrects parsing errors for message IDs 313008 & 313009 that have space after comma that lead to 'Unable to find match for dissect pattern' error.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 17, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 17, 2020 •
edited
Loading

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-13T10:43:24.891+0000

  • Duration: 179 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 2221
Skipped 385
Total 2606

Log output

Expand to view the last 100 lines of log output 

[2020-07-13T12:20:16.175Z]   Failed building wheel for MarkupSafe
[2020-07-13T12:20:16.758Z]   Failed building wheel for nose-timer
[2020-07-13T12:20:17.334Z]   Failed building wheel for PyYAML
[2020-07-13T12:20:17.960Z]   Failed building wheel for termcolor
[2020-07-13T12:20:18.223Z]   Failed building wheel for texttable
[2020-07-13T12:20:18.796Z]   Failed building wheel for jsondiff
[2020-07-13T12:20:19.368Z]   Failed building wheel for stomp.py
[2020-07-13T12:20:19.945Z]   Failed building wheel for ordered-set
[2020-07-13T12:21:06.086Z] WARNING: You are using pip version 19.2.3, however version 20.1.1 is available.
[2020-07-13T12:21:06.086Z] You should consider upgrading via the 'python -m pip install --upgrade pip' command.
[2020-07-13T12:21:06.086Z] .......SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
[2020-07-13T12:21:06.086Z] [success] 17.12% test_http_endpoint.Test.test_http_endpoint_request: 0.8178s
[2020-07-13T12:21:06.086Z] [success] 14.44% test_http_endpoint.Test.test_http_endpoint_get_request: 0.6894s
[2020-07-13T12:21:06.086Z] [success] 13.97% test_http_endpoint.Test.test_http_endpoint_wrong_content_header: 0.6673s
[2020-07-13T12:21:06.086Z] [success] 13.91% test_http_endpoint.Test.test_http_endpoint_missing_auth_value: 0.6643s
[2020-07-13T12:21:06.086Z] [success] 13.89% test_http_endpoint.Test.test_http_endpoint_empty_body: 0.6634s
[2020-07-13T12:21:06.086Z] [success] 13.84% test_http_endpoint.Test.test_http_endpoint_malformed_json: 0.6611s
[2020-07-13T12:21:06.086Z] [success] 12.82% test_http_endpoint.Test.test_http_endpoint_wrong_auth_value: 0.6123s
[2020-07-13T12:21:06.086Z] ----------------------------------------------------------------------
[2020-07-13T12:21:06.086Z] Ran 128 tests in 4.796s
[2020-07-13T12:21:06.086Z] 
[2020-07-13T12:21:06.086Z] OK (SKIP=121)
[2020-07-13T12:21:06.086Z] >> python test: Unit Testing Complete
[2020-07-13T12:21:06.240Z] Recording test results
[2020-07-13T12:21:09.714Z] Stashed 2 file(s)
[2020-07-13T12:21:09.732Z] Archiving artifacts
[2020-07-13T13:41:43.246Z] Cancelling nested steps due to timeout
[2020-07-13T13:41:43.249Z] ...........Sending interrupt signal to process
[2020-07-13T13:41:46.169Z] Sending interrupt signal to process
[2020-07-13T13:41:57.937Z] failed to run compiled magefile: signal: terminated
[2020-07-13T13:41:58.303Z] script returned exit code 255
[2020-07-13T13:41:58.906Z] Recording test results
[2020-07-13T13:42:01.917Z] Stashed 3 file(s)
[2020-07-13T13:42:01.943Z] Archiving artifacts
[2020-07-13T13:42:03.396Z] + curl -sSLo codecov https://codecov.io/bash
[2020-07-13T13:42:03.661Z] + FILE=auditbeat/build/coverage/full.cov
[2020-07-13T13:42:03.661Z] + [ -f auditbeat/build/coverage/full.cov ]
[2020-07-13T13:42:03.661Z] + FILE=filebeat/build/coverage/full.cov
[2020-07-13T13:42:03.661Z] + [ -f filebeat/build/coverage/full.cov ]
[2020-07-13T13:42:03.661Z] + FILE=heartbeat/build/coverage/full.cov
[2020-07-13T13:42:03.662Z] + [ -f heartbeat/build/coverage/full.cov ]
[2020-07-13T13:42:03.662Z] + FILE=libbeat/build/coverage/full.cov
[2020-07-13T13:42:03.662Z] + [ -f libbeat/build/coverage/full.cov ]
[2020-07-13T13:42:03.662Z] + FILE=metricbeat/build/coverage/full.cov
[2020-07-13T13:42:03.662Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-07-13T13:42:03.662Z] + FILE=packetbeat/build/coverage/full.cov
[2020-07-13T13:42:03.662Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-07-13T13:42:03.662Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-07-13T13:42:03.662Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-07-13T13:42:03.662Z] + FILE=journalbeat/build/coverage/full.cov
[2020-07-13T13:42:03.662Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-07-13T13:42:07.300Z] Failed in branch Filebeat x-pack
[2020-07-13T13:42:17.210Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19235/src/github.com/elastic/beats
[2020-07-13T13:42:17.789Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-13T13:42:17.882Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19235/src/github.com/elastic/beats/Lint
[2020-07-13T13:42:18.412Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19235/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-13T13:42:19.331Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19235/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-07-13T13:42:20.169Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19235/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-13T13:42:21.510Z] + cat
[2020-07-13T13:42:21.520Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-13T13:42:21.521Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-13T13:42:28.517Z] runbld>>> runbld started
[2020-07-13T13:42:28.517Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-13T13:42:29.648Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-19235' in order of occurrence in the config (last value wins).
[2020-07-13T13:42:31.106Z] runbld>>> Debug logging enabled.
[2020-07-13T13:42:31.106Z] runbld>>> Storing result
[2020-07-13T13:42:31.106Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-13T13:42:31.106Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200713134230-589DF38B
[2020-07-13T13:42:31.106Z] runbld>>> Adding system facts.
[2020-07-13T13:42:32.169Z] runbld>>> Adding vcs info for the latest commit:  4a974d909f24e660907cfd5cbd7fe885de410418
[2020-07-13T13:42:32.169Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-13T13:42:32.169Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-13T13:42:32.169Z] Processing JUnit reports with runbld...
[2020-07-13T13:42:32.169Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-13T13:42:32.457Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-13T13:42:32.457Z] runbld>>> DURATION: 36ms
[2020-07-13T13:42:32.457Z] runbld>>> STDOUT: 40 bytes
[2020-07-13T13:42:32.457Z] runbld>>> STDERR: 49 bytes
[2020-07-13T13:42:32.457Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-13T13:42:32.457Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-19235/src/github.com/elastic/beats
[2020-07-13T13:42:33.937Z] runbld>>> Storing build metadata: 
[2020-07-13T13:42:33.937Z] runbld>>> Adding test report.
[2020-07-13T13:42:33.937Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-19235/src/github.com/elastic/beats
[2020-07-13T13:42:34.651Z] runbld>>> Found 7 test output files
[2020-07-13T13:42:35.329Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 2606 Skipped: 363
[2020-07-13T13:42:35.330Z] runbld>>> Storing result
[2020-07-13T13:42:35.330Z] runbld>>> FAILURES: 0
[2020-07-13T13:42:35.602Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-13T13:42:35.602Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200713134230-589DF38B
[2020-07-13T13:42:35.885Z] runbld>>> Email notification disabled by environment variable.
[2020-07-13T13:42:35.885Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-13T13:42:43.246Z] Body did not finish within grace period; terminating with extreme prejudice
[2020-07-13T13:42:43.295Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-19235
[2020-07-13T13:42:43.852Z] [INFO] getVaultSecret: Getting secrets
[2020-07-13T13:42:44.346Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-13T13:42:47.938Z] + chmod 755 generate-build-data.sh
[2020-07-13T13:42:47.938Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19235/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19235/runs/1 ABORTED 10762693
[2020-07-13T13:42:47.938Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19235/runs/1/steps/?limit=10000 -o steps-info.json
[2020-07-13T13:42:50.422Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19235/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-07-13T13:42:51.768Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19235/runs/1/log/ -o pipeline-log.txt

ajoliveira and others added 2 commits July 12, 2020 22:56
@ajoliveira @adriansr
[Filebeat] Fix Cisco ASA dissect pattern for 313008 & 313009 (elastic…
f215dd6 
…#19149)

Extra space after column causes 'Unable to find match for dissect pattern' error.

(cherry picked from commit 155013a)
@adriansr
Update test files
2519e5b
@adriansr adriansr merged commit 3382f55 into elastic:7.x Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriansr @elasticmachine @marc-gr @ajoliveira