Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cloudfoundry metrics collection using consumer v1 API #19268

Merged
merged 11 commits into from
Jun 24, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jun 18, 2020

What does this PR do?

Continues with #19125 to add support to Cloud Foundry consumer v1 API in Metricbeat too.

version can be used to select if v1 or v2 version should be used.

Why is it important?

We already support the v2 API, but we saw that this API is not reliable enough (see #18202 and #18282).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Run metricbeat with the cloudfoundry input and check that it collects events. Try these combinations of the version option:
    • No version option (what would use v1)
    • version: v1.
    • version: v2.
    • For other values of version it should fail to start.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@jsoriano jsoriano added [zube]: In Progress in progress Pull request is currently in progress. Team:Platforms Label for the Integrations - Platforms team labels Jun 18, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@jsoriano jsoriano self-assigned this Jun 18, 2020
@zube zube bot unassigned jsoriano Jun 18, 2020
@jsoriano jsoriano self-assigned this Jun 18, 2020
@jsoriano jsoriano marked this pull request as ready for review June 23, 2020 19:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.9.0 labels Jun 23, 2020
@blakerouse blakerouse mentioned this pull request Jun 24, 2020
18 tasks
@jsoriano jsoriano merged commit 5645491 into elastic:master Jun 24, 2020
@jsoriano jsoriano deleted the cloudfoundry-metricbeat-v1 branch June 24, 2020 17:03
jsoriano added a commit to jsoriano/beats that referenced this pull request Jun 24, 2020
…elastic#19268)

As previously done for the Filebeat input, add support for metrics collection
in the Metricbeat module using the consumer v1 API. It reuses the same
Doppler consumer used in Filebeat.

v2 API is still supported, and can be selected by adding `version: v2` to the
configuration, v1 is used by default as is in principle more reliable.

(cherry picked from commit 5645491)
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Jun 24, 2020
jsoriano added a commit that referenced this pull request Jun 25, 2020
…#19268) (#19372)

As previously done for the Filebeat input, add support for metrics collection
in the Metricbeat module using the consumer v1 API. It reuses the same
Doppler consumer used in Filebeat.

v2 API is still supported, and can be selected by adding `version: v2` to the
configuration, v1 is used by default as is in principle more reliable.

(cherry picked from commit 5645491)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…elastic#19268)

As previously done for the Filebeat input, add support for metrics collection
in the Metricbeat module using the consumer v1 API. It reuses the same
Doppler consumer used in Filebeat.

v2 API is still supported, and can be selected by adding `version: v2` to the
configuration, v1 is used by default as is in principle more reliable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Pull request is currently in progress. Team:Platforms Label for the Integrations - Platforms team v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metricbeat : Cloudfoundry input dropping healthwatch metrics
4 participants