Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19107 to 7.x: Allow host.* fields to be disabled in Suricata module #19293

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jun 18, 2020

Cherry-pick of PR #19107 to 7.x branch. Original message:

What does this PR do?

If forwarded as configured as a tag (e.g. var.tags: [forwarded]) for the Suricata module then Filebeat will not add host fields to events. This is for use cases where Suricata is analyzing forwarded data (like from a network tap or mirror port).

Why is it important?

We want Filebeat to follow Elastic Common Schema. And setting host with the correct value is part of that. By setting (or not setting host) we can better interpret events. Without this change the Filebeat host is being attributed as the source even if data was received over a network tap or mirror port.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

If `forwarded` as configured as a tag (e.g. `var.tags: [forwarded]`) for the Suricata module then Filebeat will not add `host` fields to events. This is for use cases where Suricata is analyzing forwarded data (like from a network tap or mirror port).

Relates: elastic#13920
(cherry picked from commit 79d79bf)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 18, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 18, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [andrewkroh commented: run tests]

  • Start Time: 2020-06-18T21:04:55.705+0000

  • Duration: 52 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 3938
Skipped 678
Total 4616

@andrewkroh
Copy link
Member Author

run tests

@andrewkroh andrewkroh merged commit 5e4077d into elastic:7.x Jun 26, 2020
@andrewkroh andrewkroh deleted the backport_19107_7.x branch January 14, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants