-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat][GSuite] Initial implementation of SAML and User Accounts filesets #19329
Conversation
Pinging @elastic/siem (Team:SIEM) |
68fe137
to
dd80383
Compare
4af96b3
to
f558ba5
Compare
d43792e
to
1e391e5
Compare
1e391e5
to
9544599
Compare
c34f88e
to
24fd4e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really really good. Couple of small questions on ECS types & categories.
x-pack/filebeat/module/gsuite/saml/test/gsuite-saml-test.json.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/gsuite/saml/test/gsuite-saml-test.json.log-expected.json
Outdated
Show resolved
Hide resolved
24fd4e6
to
5d94306
Compare
0e5c307
to
e66f25e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this, but it'd be nice if @leehinman or @andrewkroh could sign off on the updated changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ilesets (elastic#19329) * GSuite initial implementation of SAML fileset * Document fields and generate test file * Add documentation * Split fields and improve docs * Add change to CHANGELOG * Rename config file and clean docs * Adds user accounts fileset * Add delegated user to google oauth * Add types and make changes to common pipeline * Do not stop input if array key not found * Fix docs * Setup for date cursor * Add beta tag * CHANGELOG message * Improve ECS mappings * Change cateogrization and types of various fields * Change event.type to start * Improve doc references (cherry picked from commit 7abd67d)
…ilesets (#19329) (#19726) * GSuite initial implementation of SAML fileset * Document fields and generate test file * Add documentation * Split fields and improve docs * Add change to CHANGELOG * Rename config file and clean docs * Adds user accounts fileset * Add delegated user to google oauth * Add types and make changes to common pipeline * Do not stop input if array key not found * Fix docs * Setup for date cursor * Add beta tag * CHANGELOG message * Improve ECS mappings * Change cateogrization and types of various fields * Change event.type to start * Improve doc references (cherry picked from commit 7abd67d)
…ilesets (elastic#19329) * GSuite initial implementation of SAML fileset * Document fields and generate test file * Add documentation * Split fields and improve docs * Add change to CHANGELOG * Rename config file and clean docs * Adds user accounts fileset * Add delegated user to google oauth * Add types and make changes to common pipeline * Do not stop input if array key not found * Fix docs * Setup for date cursor * Add beta tag * CHANGELOG message * Improve ECS mappings * Change cateogrization and types of various fields * Change event.type to start * Improve doc references
What does this PR do?
This PR adds a GSuite module to filebeat that uses
httpjson
as input, and creates a SAML and User accounts filesets for it, which consumes events from https://developers.google.com/admin-sdk/reports/v1/appendix/activity/[saml|user-accounts]Why is it important?
It is the first step to allow users to consume
gsuite
activity reports. It sets the common pieces for the next filesets and since SAML and User accounts are the simplest ones makes it easy to test and validate the module functionality.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
Depends on
#19246