Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Stream fields removed from injected configurations #19356

Merged
merged 6 commits into from
Jun 25, 2020
Merged

[Ingest Manager] Stream fields removed from injected configurations #19356

merged 6 commits into from
Jun 25, 2020

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

Followup to #19128 removes stream.* fields from being injected into events as a add_fields processor.

Why is it important?

Migrated to dataset.* fields

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added review needs_backport PR is waiting to be backported to other branches. Team:Ingest Management Ingest Management:beta1 Group issues for ingest management beta1 labels Jun 24, 2020
@michalpristas michalpristas self-assigned this Jun 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 24, 2020
@michalpristas michalpristas changed the title removed [Ingest Manager] Stream fields removed from injected configurations Jun 24, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 24, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19356 updated]

  • Start Time: 2020-06-25T09:03:06.857+0000

  • Duration: 37 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 539
Skipped 127
Total 666

ruflin
ruflin reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not run it locally yet but want to double check: Is it also cleaned up for the monitoring data we ship?

go.sum Outdated
@@ -223,6 +223,7 @@ github.com/eapache/queue v1.1.0 h1:YOEu7KNc61ntiQlcEeUIoDTJ2o8mQznoNvUhiigpIqc=
github.com/eapache/queue v1.1.0/go.mod h1:6eCeP0CKFpHLu8blIFXhExK/dRa7WDZfr6jVFPTqq+I=
github.com/eclipse/paho.mqtt.golang v1.2.1-0.20200121105743-0d940dd29fd2 h1:DW6WrARxK5J+o8uAKCiACi5wy9EK1UzrsCpGBPsKHAA=
github.com/eclipse/paho.mqtt.golang v1.2.1-0.20200121105743-0d940dd29fd2/go.mod h1:H9keYFcgq3Qr5OUJm/JZI/i6U7joQ8SYLhZwfeOo6Ts=
github.com/elastic/beats v7.6.2+incompatible h1:jHdLv83KURaqWUC6f55iMyVP6LYZrgElfeqxKWcskVE=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this is just my vscode

ruflin
ruflin approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Please run the agent against ES and assure no indices contain stream.* fields.

@michalpristas michalpristas mentioned this pull request Jun 25, 2020
Closed
@michalpristas michalpristas merged commit bcce257 into elastic:master Jun 25, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Jun 25, 2020
@michalpristas
[Ingest Manager] Stream fields removed from injected configurations (e…
bfb0047 
…lastic#19356)

* removed

* updated tests

* Update go.sum

* monitoring data
@michalpristas michalpristas mentioned this pull request Jun 25, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request Jun 26, 2020
@michalpristas
[Ingest Manager] Stream fields removed from injected configurations (#…
2f89ca5 
…19356) (#19389)

* removed

* updated tests

* Update go.sum

* monitoring data
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@michalpristas @melchiormoulin
[Ingest Manager] Stream fields removed from injected configurations (e…
266ca93 
…lastic#19356)

* removed

* updated tests

* Update go.sum

* monitoring data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@michalpristas michalpristas

Labels
Ingest Management:beta1 Group issues for ingest management beta1 needs_backport PR is waiting to be backported to other branches. review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @ruflin