Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close changelog for 7.8.1 #19669

Merged
merged 4 commits into from
Jul 14, 2020

Conversation

kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Jul 6, 2020

What does this PR do?

Update Changelogs

Why is it important?

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kuisathaverat kuisathaverat self-assigned this Jul 6, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2020
@kuisathaverat kuisathaverat requested review from andrewkroh, urso and a team July 6, 2020 11:48
@kuisathaverat kuisathaverat added the Team:Automation Label for the Observability productivity team label Jul 6, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 6, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19669 updated]

  • Start Time: 2020-07-13T15:46:19.364+0000

  • Duration: 23 min 33 sec

@@ -34,6 +36,8 @@ upgrade.
* <<release-notes-7.0.0-beta1>>
* <<release-notes-7.0.0-alpha2>>
* <<release-notes-7.0.0-alpha1>>
* <<release-notes-6.8.11>>
* <<release-notes-6.8.10>>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these sections already in the Changelog.asciidoc? You might need to copy 6.8.10 and 6.8.11 changelog to the 7.8, 7.x, and master branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspected something was missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every branch has a different changelog, even the master branch does not have all release notes versions, I will rid of that part

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every branch has a different changelog

The changelog in each branch must be held consistent. The changelog and documentation is generated from the release branch. This means that 7.8 release branch must include all changelogs for past 7.7, 7.6, 7.5, 7.4, 7.3, 7.2, 7.1, ... 6.8, ... releases

The 7.8 branch will contain all changelogs up to the most recent 7.8.x patch release.
The 7.9 branch will contain all changelogs up to the most recent 7.9.x patch release.

The changelogs in the 7.x and master branch need to be kept in sync with the actual release branches.

If the changelogs in the branches differ, then we're missing the required updates in some branches.

@kuisathaverat kuisathaverat requested a review from urso July 13, 2020 15:19
@kuisathaverat
Copy link
Contributor Author

@urso can you take a last look to this.

@urso
Copy link

urso commented Jul 13, 2020

The 7.8.1 changes look good. We still need to add 7.7.1 and old 6.8.10 changelog. The release notes are published here per release branch: https://www.elastic.co/guide/en/beats/libbeat/current/release-notes.html

comparing 7.8 and 7.7 or 6.8 branch the notes are currently inconsistent:

The 7.8 branch is missing at least 7.7.1 (which was release before 7.8.0) and there have been added some minor release we're still missing in the changelog. The 7.x and master changelogs also need some cleanup. Do we plan to cleanup the 7.8 changelog in a follow up PR?

@kuisathaverat
Copy link
Contributor Author

@urso We noticed the differences between release notes and the gaps in some of them, we can open an issue for that and fix all the changelogs in a follow-up. So if the changelog in this PR is correct, we could merge it and fix the changelog issues later

@urso
Copy link

urso commented Jul 14, 2020

@urso We noticed the differences between release notes and the gaps in some of them, we can open an issue for that and fix all the changelogs in a follow-up. So if the changelog in this PR is correct, we could merge it and fix the changelog issues later

SGTM. Let's do this.

@kuisathaverat kuisathaverat merged commit c63a73f into elastic:7.8 Jul 14, 2020
@kuisathaverat kuisathaverat deleted the close_changelog_7.8.1 branch December 24, 2020 11:07
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Close changelog for 7.8.1

* Update libbeat/docs/release.asciidoc

* Update libbeat/docs/release.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants