Cherry-pick #19507 to 7.x: Agent unenroll #19696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
review
backport
Team:Ingest Management
Ingest Management:beta1
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
|
blakerouse
approved these changes
Jul 7, 2020
| // clean action store | ||
| // if err := os.Remove(info.AgentActionStoreFile()); err != nil && !os.IsNotExist(err) { | ||
| // return errors.New(err, "failed to clear action store") | ||
| // } |
There was a problem hiding this comment.
Probably would have been best in the other PR to just remove this, instead of leaving it commented out.
Just wanted to call that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19507 to 7.x branch. Original message:
What does this PR do?
This PR works with draft from here: elastic/kibana#70031
Accepts UNENROLL actions and stop all the processes it has started.
Why is it important?
Removing endpoint on unenroll.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.