Move O365audit input to v2 input API #19719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
review
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
adriansr
approved these changes
Jul 8, 2020
|
Here's the debug logs for the test. First run, fetch events starting from a week ago, until a blob of events is found ( Second run, Also the previous |
4 tasks
urso
added
v7.9.0
and removed
needs_backport
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jul 9, 2020
(cherry picked from commit 03bedd7)
urso
pushed a commit
that referenced
this pull request
Jul 13, 2020
andresrc
added
test-plan-added
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move o365audit input to use the v2 input API.
The change treats the tuple 'tenantID' and 'contentType' as the stream identifier. The cursor input package starts one go-routine per stream, ensuring that no two inputs can collect events for the same stream.
Not yet documented (not sure if we should): the cursor input manager adds a
idsetting to each input it manages. The ID settings can be configured manualy and will become part of the stream ID in the statestore. This allows users to configure 2 inputs collecting from the same streams.(Needs docs): The cursor input manager runs a go-routine in the background deleting old states no input or pending event (to be ACKed by outputs) is active for. Each entry in the store has a TTL. And entry is to be removed if there is no active input, all events for the stream have been acked, and
lastUpdateTimestamp + TTL < now. The TTL is configured viaclean_timeout. The defaultclean_timeoutis 30 minutes.The default clean_timeout can be configured by setting 'DefaultCleanTimeout' in the InputManager in the
Pluginfunction.When the beat is restarted the cleanup will not delete entries yet. Instead the reference time for old entries is set to 'beatStartTimestamp'. After restart old entries that don't get picked up are deleted after
beatStartTimestamp + TTL < now.Why is it important?
This enables the input to store the read positions in the statestore between restarts.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
@adriansr can you add details about required manual testing please?
Related issues