Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #19759 to 7.x: Send the config revision down to the endpoint application. #19802

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Cherry-pick #19759 to 7.x: Send the config revision down to the endpoint application. #19802

merged 1 commit into from
Jul 9, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Jul 9, 2020

Cherry-pick of PR #19759 to 7.x branch. Original message:

What does this PR do?

This PR make sure we forward the config revision down to the endpoint.

Why is it important?

The endpoint uses that information to send information back to Elasticsearch.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Send the config revision down to the endpoint application. (elastic#1…
4725f3a 
…9759)

* Send the config revision down to the endpoint application.

This PR make sure we forward the config revision down to the endpoint.

(cherry picked from commit d03432b)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 9, 2020
@ph ph requested a review from blakerouse July 9, 2020 16:01
michalpristas
michalpristas approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19802 opened]

  • Start Time: 2020-07-09T16:01:32.761+0000

  • Duration: 33 min 57 sec

@ph ph merged commit dc621a5 into elastic:7.x Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse

Assignees
No one assigned
Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @michalpristas