Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent info docs and ci test pr #19805

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Agent info docs and ci test pr #19805

merged 1 commit into from
Sep 17, 2020

Conversation

EricDavisX
Copy link
Contributor

Research into Beats ci system and usage with intention to update it eventually to build a local docker container of the Elastic Agent to facilitate pr testing in ci.

What does this PR do?

This is a test pr, but it has a real change we could review as of now, I have added a link to the Elastic Agent in the README.md file.

This will remain a draft PR and of course get help to push it thru correctly and document all requirements before attempting to merge in to master.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@EricDavisX EricDavisX added Ingest Management:beta1 Group issues for ingest management beta1 Team:Ingest Management labels Jul 9, 2020
@EricDavisX EricDavisX self-assigned this Jul 9, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 9, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-13T09:39:46.905+0000

  • Duration: 22 min 35 sec

@EricDavisX
Copy link
Contributor Author

/package

@EricDavisX
Copy link
Contributor Author

/packaging

@EricDavisX EricDavisX mentioned this pull request Jul 10, 2020
Closed
@kuisathaverat
Copy link
Contributor

/package

2 similar comments
@kuisathaverat
Copy link
Contributor

/package

@kuisathaverat
Copy link
Contributor

/package

@EricDavisX EricDavisX marked this pull request as ready for review August 25, 2020 21:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@EricDavisX
Copy link
Contributor Author

I'm not sure if we decided the cited / package call was working... but I'm not currently following up on this. We can review and merge as desired the minor docs change.

@EricDavisX
Copy link
Contributor Author

/package

1 similar comment
@EricDavisX
Copy link
Contributor Author

/package

@ph
Copy link
Contributor

ph commented Sep 16, 2020

@EricDavisX Why you want to build the package, Are you trying to fix the readme shipped with the Elastic Agent, If so the code we need to modify is not in this place. #21122

@EricDavisX
Copy link
Contributor Author

i was using this pr that i was imminently merging to test the e2e test locally against the package created by this pr. Manu says its available and ready to be used manually - super exciting, just validating it works.

@ph
Copy link
Contributor

ph commented Sep 16, 2020

oh sneaky @EricDavisX :D

@EricDavisX
Copy link
Contributor Author

So, using this lil pr I confirmed it. I ran the test with the Agent from my pr, since it was packaged and its stored in gcp storage it can be accessed.

for ex:
OP_LOG_LEVEL=TRACE DEVELOPER_MODE=true ELASTIC_AGENT_USE_CI_SNAPSHOTS=true ELASTIC_AGENT_VERSION=pr-19805 godog -t "stand_alone_mode"

the package call is /package

I ran it from the e2e-testing repo, in the Ingest-manager folder:
https://github.com/elastic/e2e-testing/tree/master/e2e/_suites/ingest-manager

FYI. And now I'll merge this, too.

@EricDavisX EricDavisX merged commit 9cf36b7 into master Sep 17, 2020
@EricDavisX EricDavisX deleted the build-docker-container-in-ci branch September 17, 2020 14:24
v1v added a commit to v1v/beats that referenced this pull request Sep 18, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/ci-pipeli…
20788d9 
…ne-2.0

* upstream/master:
  Add Cloud Foundry dashboards for metricbeat (elastic#21124)
  [Metricbeat][Kibana] Apply backoff when errored at getting usage stats (elastic#20772)
  Update input-log.asciidoc (elastic#20965) (elastic#21153)
  Remove redirects page (elastic#19574)
  [Ingest Manager] Fixed input types for filebeat (elastic#21131)
  docs: add beat specific install widget (elastic#21050)
  docs: link to APM privs for API keys (elastic#20911)
  Fix index out of range error when getting AWS account name (elastic#21101)
  Agent info docs and ci test pr (elastic#19805)
  Handling missing counters in application_pool metricset  (elastic#21071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas

Assignees

@EricDavisX EricDavisX

Labels
Ingest Management:beta1 Group issues for ingest management beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricDavisX @elasticmachine @kuisathaverat @ph