Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19537 to 7.8: Fix empty field error in the iis/application pool metricset #19887

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Jul 14, 2020

Cherry-pick of PR #19537 to 7.8 branch. Original message:

What does this PR do?

Fixes errors as:

"metricset":{"name":"application_pool","period":10000},"service":{"type":"iis"}}, Private:interface {}(nil), TimeSeries:true}, Flags:0x0, Cache:publisher.EventCache{m:common.MapStr(nil)}} (status=400): {"type":"mapper_parsing_exception","reason":"failed to parse","caused_by":{"type":"illegal_argument_exception","reason":"field name cannot be an empty string"}}

also improves refresh functionality

Why is it important?

Errors

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run the IIS module wit the application pool metricset enabled

…19537)

* fix

* update test

* changelog

* change

* refactor

* close

(cherry picked from commit 93e43e7)
@narph narph added backport Team:Integrations Label for the Integrations team labels Jul 14, 2020
@narph narph self-assigned this Jul 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 14, 2020
@narph narph merged commit 3d86d9f into elastic:7.8 Jul 14, 2020
@narph narph deleted the backport_19537_7.8 branch July 14, 2020 13:51
@zube zube bot removed the [zube]: Done label Oct 13, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…plication pool metricset (elastic#19887)

* Fix empty field error in the iis/application pool metricset (elastic#19537)

* fix

* update test

* changelog

* change

* refactor

* close

(cherry picked from commit 134324e)

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants