Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat Module] Defender ATP - Adding dashboard #20058

Merged
merged 3 commits into from
Jul 21, 2020
Merged

[Filebeat Module] Defender ATP - Adding dashboard #20058

merged 3 commits into from
Jul 21, 2020

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jul 20, 2020 •
edited
Loading

What does this PR do?

This PR adds a dashboard to the Microsoft Defender ATP module and updates the documentation with some styling fixes.

Why is it important?

Adds missing components to the documentation and adds some planned fixes to the docs to separate DHCP and the Defender ATP fileset

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 20, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 20, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [marc-gr commented: jenkins run tests]

  • Start Time: 2020-07-21T07:28:17.842+0000

  • Duration: 53 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 5508
Skipped 828
Total 6336

@P1llus
Copy link
Member Author

P1llus commented Jul 21, 2020

Jenkins test this

@marc-gr
Copy link
Contributor

marc-gr commented Jul 21, 2020

jenkins run tests

@marc-gr marc-gr merged commit c306d45 into elastic:master Jul 21, 2020
@marc-gr marc-gr mentioned this pull request Jul 21, 2020
Merged
5 tasks
@marc-gr marc-gr mentioned this pull request Jul 21, 2020
Merged
5 tasks
@marc-gr marc-gr added the v7.9.0 label Jul 21, 2020
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Jul 28, 2020
@P1llus @marc-gr
[Filebeat Module] Defender ATP - Adding dashboard (elastic#20058)
eef760d 
* adding dashboard to ATP, work in progress

* adding dashboard to ATP, removing a unused file, and fixing styling issues in the doc

* added description to dashboard and visualizations

(cherry picked from commit c306d45)
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Jul 28, 2020
@P1llus @marc-gr
[Filebeat Module] Defender ATP - Adding dashboard (elastic#20058)
16d2433 
* adding dashboard to ATP, work in progress

* adding dashboard to ATP, removing a unused file, and fixing styling issues in the doc

* added description to dashboard and visualizations

(cherry picked from commit c306d45)
marc-gr added a commit that referenced this pull request Jul 28, 2020
@marc-gr @P1llus
[Filebeat Module] Defender ATP - Adding dashboard (#20058) (#20093)
b1e76c7 
* adding dashboard to ATP, work in progress

* adding dashboard to ATP, removing a unused file, and fixing styling issues in the doc

* added description to dashboard and visualizations

(cherry picked from commit c306d45)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
marc-gr added a commit that referenced this pull request Jul 28, 2020
@marc-gr @P1llus
[Filebeat Module] Defender ATP - Adding dashboard (#20058) (#20092)
f503865 
* adding dashboard to ATP, work in progress

* adding dashboard to ATP, removing a unused file, and fixing styling issues in the doc

* added description to dashboard and visualizations

(cherry picked from commit c306d45)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
v1v added a commit to v1v/beats that referenced this pull request Jul 29, 2020
@v1v
Merge remote-tracking branch 'upstream/7.9' into backport/7.9/pr-19960
59a6124 
* upstream/7.9: (32 commits)
  feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282) (elastic#20301)
  Cisco ASA: Fix message 106100 (elastic#20245) (elastic#20277)
  [CI] Change upstream reference (elastic#20296) (elastic#20297)
  [docs] Fix Windows download link for agent (elastic#20258) (elastic#20290)
  Cherry-pick to 7.9: [docs] Rename release highlights to what's new (elastic#20255) (elastic#20285)
  Elastic agent on k8s (elastic#19727) (elastic#20262)
  [Filebeat Module] Defender ATP - Adding dashboard (elastic#20058) (elastic#20093)
  fix: use a fixed worker type for tests (elastic#20130) (elastic#20247)
  [Elastic Agent] Fix Windows powershell install service script (elastic#20203) (elastic#20252)
  [Ingest Manager] Fixed unzip on older windows  (elastic#20088) (elastic#20109)
  adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) (elastic#20237)
  [Filebeat][Gsuite] Make GSuite docs more clear (elastic#19981) (elastic#20067)
  Increase index.max_docvalue_fields_search to 200 (elastic#20218) (elastic#20221)
  Call host parser only once when building light metricsets (elastic#20149) (elastic#20190)
  [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) (elastic#20212)
  [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) (elastic#20217)
  [libbeat] Fix write error in ensureWriter.Write (elastic#20112) (elastic#20145)
  Cherry-pick elastic#20127 to 7.9: Fix failing unit tests on windows  (elastic#20180)
  Remove f5/firepass rsa2elk fileset (elastic#20160) (elastic#20206)
  Cherry-pick elastic#20138 to 7.9: [Filebeat] Update crowdstrike module (elastic#20177)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@P1llus @melchiormoulin
[Filebeat Module] Defender ATP - Adding dashboard (elastic#20058)
0eb10d6 
* adding dashboard to ATP, work in progress

* adding dashboard to ATP, removing a unused file, and fixing styling issues in the doc

* added description to dashboard and visualizations
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@marc-gr @P1llus
[Filebeat Module] Defender ATP - Adding dashboard (elastic#20058) (el…
81524ed 
…astic#20093)

* adding dashboard to ATP, work in progress

* adding dashboard to ATP, removing a unused file, and fixing styling issues in the doc

* added description to dashboard and visualizations

(cherry picked from commit 14fb51d)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat review v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@P1llus @elasticmachine @marc-gr @andrewkroh