-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #19321 to 7.x: DNS over TLS support for DNS processor #20090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-gr
added
[zube]: In Review
backport
Team:Integrations
Label for the Integrations team
Team:SIEM
labels
Jul 21, 2020
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 21, 2020
Pinging @elastic/siem (Team:SIEM) |
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 21, 2020
andrewkroh
reviewed
Jul 21, 2020
CHANGELOG.next.asciidoc
Outdated
@@ -410,6 +410,7 @@ field. You can revert this change by configuring tags for the module and omittin | |||
- Add the `overwrite_keys` configuration option to the dissect processor. {pull}19464[19464] | |||
- Add support to trim captured values in the dissect processor. {pull}19464[19464] | |||
- Added the `max_cached_sessions` option to the script processor. {pull}19562[19562] | |||
- Add support for DNS over TLS for the dns_processor. {pull}19321[19321] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Add support for DNS over TLS for the dns_processor. {pull}19321[19321] | |
- Add support for DNS over TLS for the `dns` processor. {pull}19321[19321] |
The processor name is just dns
.
andrewkroh
approved these changes
Jul 21, 2020
Collaborator
marc-gr
force-pushed
the
backport_19321_7.x
branch
4 times, most recently
from
July 28, 2020 06:52
0bdde4e
to
3ed8368
Compare
* DNS over TLS DoT support elastic#16663 * added changelog elastic#19321 * Update dns.asciidoc * added testsuite for elastic#19321 * Fix CHANGELOG entries and lint fixes * Apply suggestions from code review Co-authored-by: Marc Guasch <marc.guasch@elastic.co> Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit 89bfb6c)
marc-gr
force-pushed
the
backport_19321_7.x
branch
from
July 31, 2020 11:03
3ed8368
to
ccf4d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19321 to 7.x branch. Original message:
Label: Enhancement
What does this PR do?
Implement DNS over TLS (DoT) handler for the DNS Processor. #16663
Why is it important?
Now you can securely query for reverseDNS lookups across the internet. E.g. cloudflare 1.1.1.1 supports DNS over TLS
Checklist
I would need a bit of help here. Do I have to touch every beat config, or is the DNS processor page in the docs rendered from the libbeat ascii doc file?
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Minimum filebeat config
Full filebeat config
Example doc
tls
,udp
. If left empty it will revert to defaultudp
Related issues
Use cases
Logs
TLS
UDP / no config