Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #19349 to 7.x: [Packetbeat] HTTP: Improve support for 100-continue #15830 #20234

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Cherry-pick #19349 to 7.x: [Packetbeat] HTTP: Improve support for 100-continue #15830 #20234

merged 1 commit into from
Jul 28, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 27, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #19349 to 7.x branch. Original message:

What does this PR do?

Improve support for 100-continue #15830

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

nosetests ./tests/system/test_0070_http_100_continue.py

Related issues

#15830

@OhBonsai @marc-gr
[Packetbeat] HTTP: Improve support for 100-continue elastic#15830 (el…
ce39f95 
…astic#19349)

* refactor(packet beat): Improve support for 100-continue

* test(packetbeat): 100-continue only generate one event without error

* test(packetbeat): 100-continue only generate one event without error

* Update packetbeat/protos/http/http.go

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>

* delete unused string

* Fix format issue

Co-authored-by: Marc Guasch <marc.guasch@elastic.co>
Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
(cherry picked from commit 41bc8c6)
@marc-gr marc-gr requested a review from a team as a code owner July 27, 2020 09:26
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20234 opened]

  • Start Time: 2020-07-27T09:27:08.681+0000

  • Duration: 45 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 181
Skipped 1
Total 182

@marc-gr marc-gr merged commit a6a9cd5 into elastic:7.x Jul 28, 2020
@marc-gr marc-gr deleted the backport_19349_7.x branch July 28, 2020 06:55
@zube zube bot removed the [zube]: Done label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-gr @elasticmachine @adriansr @OhBonsai