[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20305

ChrsMark · 2020-07-29T10:17:05Z

What does this PR do?

This PR ignores ErrInputNotFinished error occur in autodiscover stop/start process. This is required in order to avoid having stoped configs that never come back since the start event fails due to this error on first attempt if the previous state is not cleaned yet.

Currently configs that fail due to ErrInputNotFinished are skipped at

beats/libbeat/autodiscover/autodiscover.go

Line 212 in fb52d26

continue

. However, this is not a config error but a state error and in that case we need to add them in the list of configs at

beats/libbeat/autodiscover/autodiscover.go

Line 223 in fb52d26

a.configs[eventID][hash] = &reload.ConfigWithMeta{

so as to be handled properly by the retry mechanism of autodiscover at

beats/libbeat/autodiscover/autodiscover.go

Line 164 in fb52d26

retry = err != nil

Why is it important?

In order to resolve a permanent issue with updated Pods, which makes Filebeat stop collecting logs after a Pod is updated.

How to test this PR locally

Deploy Filebeat on k8s using the following config for autodiscover (set a valid output too so as to ship logs to ES):

filebeat.autodiscover:
  providers:
    - type: kubernetes
      node: ${NODE_NAME}
      templates:
        - condition:
            equals:
              kubernetes.pod.name: "mytarget3"
          config:
            - type: container
              paths:
                - /var/log/containers/*${data.kubernetes.container.id}.log

While Filebeat is up and running deploy a target pod to be autodiscovered and make Filebeat collects its logs:

---
apiVersion: v1
kind: Pod
metadata:
  name: mytarget3
  labels:
    app: test
spec:
  containers:
    - name: test
      image: ubuntu:latest
      command:
        - bash
        - -c
        - |
          #!/bin/bash
          echo "$(date): started the process"

          while :
          do
                 echo "$(date): sleeping 5 seconds"
                 sleep 5
          done

Update the target Pod's manifest by adding an extra label like team: qa
apply the Pod's update with kubectl apply -f <manifest_filename>.yml
Make sure that after a while, Filebeat continues collecting logs after the update of the Pod.

Signed-off-by: chrismark <chrismarkou92@gmail.com>

elasticmachine · 2020-07-29T10:17:08Z

Pinging @elastic/integrations-platforms (Team:Platforms)

Signed-off-by: chrismark <chrismarkou92@gmail.com>

elasticmachine · 2020-07-29T11:20:51Z

💔 Tests Failed

Expand to view the summary

Build stats

Build Cause: [Pull request #20305 updated]
Start Time: 2020-07-29T15:10:24.965+0000
Duration: 74 min 38 sec

Test stats 🧪

Test	Results
Failed	16
Passed	17672
Skipped	1903
Total	19591

Test errors

Expand to view the tests failures

Name: Build and Test / Libbeat / Libbeat oss / TestDockerStart – docker
- Age: 1
- Duration: 12.14
- Error Details: Failed
Name: Build and Test / Libbeat / Libbeat oss / TestReplaceClientWorker – pipeline
- Age: 1
- Duration: 21.19
- Error Details: Failed
Name: Build and Test / Libbeat / Libbeat oss / TestReplaceClientWorker/network_client – pipeline
- Age: 1
- Duration: 20.06
- Error Details: Failed
Name: Build and Test / Auditbeat x-pack / test_connected_udp_ipv4 – test_system_socket.Test
- Age: 1
- Duration: 60.029
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_connected_udp_ipv6 – test_system_socket.Test
- Age: 1
- Duration: 60.023
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_dns_enrichment – test_system_socket.Test
- Age: 1
- Duration: 60.116
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_dns_long_request – test_system_socket.Test
- Age: 1
- Duration: 60.11
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_dns_udp_ipv6 – test_system_socket.Test
- Age: 1
- Duration: 60.123
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_dns_unidirectional_udp – test_system_socket.Test
- Age: 1
- Duration: 60.11
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_multi_udp_upv4 – test_system_socket.Test
- Age: 1
- Duration: 60.11
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_no_dns_enrichment – test_system_socket.Test
- Age: 1
- Duration: 60.111
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_tcp_ipv4 – test_system_socket.Test
- Age: 1
- Duration: 60.111
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_tcp_ipv6_disabled – test_system_socket.Test
- Age: 1
- Duration: 60.113
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_udp_ipv4 – test_system_socket.Test
- Age: 1
- Duration: 60.119
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_udp_ipv6 – test_system_socket.Test
- Age: 1
- Duration: 60.11
- Error Details: Expected exit code to be 0, but it was 1
Name: Build and Test / Auditbeat x-pack / test_udp_ipv6_disabled – test_system_socket.Test
- Age: 1
- Duration: 60.103
- Error Details: Expected exit code to be 0, but it was 1

Steps errors

Expand to view the steps failures

Name: Mage update build test
- Description: mage update build test
- Duration: 19 min 19 sec
- Start Time: 2020-07-29T15:34:55.647+0000
- log
Name: Mage build test
- Description: mage build test
- Duration: 20 min 3 sec
- Start Time: 2020-07-29T15:34:53.914+0000
- log

Log output

Expand to view the last 100 lines of log output

[2020-07-29T16:23:13.381Z]   Version:          1.0.0-rc8+dev
[2020-07-29T16:23:13.381Z]   GitCommit:        3e425f80a8c931f88e6d94a8c831b9d5aa481657
[2020-07-29T16:23:13.381Z]  docker-init:
[2020-07-29T16:23:13.381Z]   Version:          0.18.0
[2020-07-29T16:23:13.381Z]   GitCommit:        fec3683
[2020-07-29T16:23:32.765Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats
[2020-07-29T16:23:33.161Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-29T16:23:33.178Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Lint
[2020-07-29T16:23:33.290Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-07-29T16:23:33.399Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Winlogbeat-oss
[2020-07-29T16:23:33.492Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-29T16:23:33.591Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Journalbeat-oss
[2020-07-29T16:23:33.686Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Dockerlogbeat
[2020-07-29T16:23:33.789Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-07-29T16:23:33.889Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-29T16:23:33.973Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Packetbeat-Linux
[2020-07-29T16:23:34.062Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-07-29T16:23:34.156Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-29T16:23:34.240Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Heartbeat-oss
[2020-07-29T16:23:34.324Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-29T16:23:34.401Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-29T16:23:34.481Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-07-29T16:23:34.564Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-07-29T16:23:34.648Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-29T16:23:34.728Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-29T16:23:34.808Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-07-29T16:23:34.890Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Libbeat-x-pack
[2020-07-29T16:23:34.968Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-29T16:23:35.053Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-29T16:23:35.129Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Filebeat-Windows
[2020-07-29T16:23:35.207Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-07-29T16:23:35.285Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-29T16:23:35.362Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-29T16:23:35.440Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-29T16:23:35.527Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-29T16:23:35.617Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-29T16:23:35.714Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Packetbeat-Mac-OS-X
[2020-07-29T16:23:35.805Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-07-29T16:23:35.899Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-07-29T16:23:36.062Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-29T16:23:36.158Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Libbeat-oss
[2020-07-29T16:23:36.252Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-29T16:23:36.355Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Filebeat-oss
[2020-07-29T16:23:36.448Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-29T16:23:36.549Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-07-29T16:23:36.666Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Functionbeat-Windows
[2020-07-29T16:23:36.762Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Packetbeat-Windows
[2020-07-29T16:23:36.860Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Heartbeat-Windows
[2020-07-29T16:23:36.958Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests
[2020-07-29T16:23:37.050Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-OSS-Python-Integration-tests
[2020-07-29T16:23:37.156Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-29T16:23:37.254Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-07-29T16:23:37.353Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-07-29T16:23:37.734Z] + cat
[2020-07-29T16:23:37.734Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-29T16:23:37.734Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-29T16:23:44.345Z] runbld>>> runbld started
[2020-07-29T16:23:44.345Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-29T16:23:45.731Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-20305' in order of occurrence in the config (last value wins).
[2020-07-29T16:23:47.112Z] runbld>>> Debug logging enabled.
[2020-07-29T16:23:47.113Z] runbld>>> Storing result
[2020-07-29T16:23:47.374Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-29T16:23:47.375Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200729162346-0CB3E1AE
[2020-07-29T16:23:47.375Z] runbld>>> Adding system facts.
[2020-07-29T16:23:48.320Z] runbld>>> Adding vcs info for the latest commit:  85be0617ee4d8634df0eb2255cf757681acf5583
[2020-07-29T16:23:48.320Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-29T16:23:48.320Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-29T16:23:48.320Z] Processing JUnit reports with runbld...
[2020-07-29T16:23:48.320Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-29T16:23:48.892Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-29T16:23:48.892Z] runbld>>> DURATION: 21ms
[2020-07-29T16:23:48.892Z] runbld>>> STDOUT: 40 bytes
[2020-07-29T16:23:48.892Z] runbld>>> STDERR: 49 bytes
[2020-07-29T16:23:48.892Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-29T16:23:48.892Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats
[2020-07-29T16:23:49.835Z] runbld>>> Storing build metadata: 
[2020-07-29T16:23:49.835Z] runbld>>> Adding test report.
[2020-07-29T16:23:49.835Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats
[2020-07-29T16:23:50.406Z] runbld>>> Found 136 test output files
[2020-07-29T16:23:51.360Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-07-29T16:23:51.360Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-07-29T16:23:51.360Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-07-29T16:23:51.360Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-07-29T16:23:51.360Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-07-29T16:23:51.360Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-29T16:23:51.621Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20305/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-29T16:23:53.545Z] runbld>>> Test output logs contained: Errors: 0 Failures: 16 Tests: 19441 Skipped: 1633
[2020-07-29T16:23:53.545Z] runbld>>> Storing result
[2020-07-29T16:23:53.545Z] runbld>>> FAILURES: 16
[2020-07-29T16:23:56.843Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-29T16:23:56.843Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200729162346-0CB3E1AE
[2020-07-29T16:23:56.843Z] runbld>>> Email notification disabled by environment variable.
[2020-07-29T16:23:56.843Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-29T16:24:02.357Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20305
[2020-07-29T16:24:02.472Z] [INFO] getVaultSecret: Getting secrets
[2020-07-29T16:24:02.540Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-29T16:24:03.330Z] + chmod 755 generate-build-data.sh
[2020-07-29T16:24:03.330Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20305/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20305/runs/8 FAILURE 4418103
[2020-07-29T16:24:03.330Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20305/runs/8/steps/?limit=10000 -o steps-info.json
[2020-07-29T16:24:05.812Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20305/runs/8/tests/?status=FAILED -o tests-errors.json

Signed-off-by: chrismark <chrismarkou92@gmail.com>

jsoriano

Thanks for tackling this issue! It'd be good to have a test to cover this case. But we can leave it for a future PR.

libbeat/autodiscover/providers/kubernetes/pod.go

CHANGELOG.next.asciidoc

Signed-off-by: chrismark <chrismarkou92@gmail.com>

exekias

Change looks great to me, minor comment on the placement of the errors.go. I don't think we will be reusing this, so probably input/file is a better place

libbeat/common/errors.go

Signed-off-by: chrismark <chrismarkou92@gmail.com>

…fig checks (elastic#20305) (cherry picked from commit 7a34167)

… errors in autodiscover config checks (#20338)

… errors in autodiscover config checks (#20337) * [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks (#20305) (cherry picked from commit 7a34167) * Update CHANGELOG.next.asciidoc

… errors in autodiscover config checks (#20339) * [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks (#20305) (cherry picked from commit 7a34167) * Update CHANGELOG.next.asciidoc

…ne-2.0 * upstream/master: (29 commits) Add an explicit system test for processes on unix systems (elastic#20320) [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks (elastic#20305) [CI] Update README.md with CI references (elastic#20316) Add ECK doc links to Heartbeat docs (elastic#20284) [Filebeat] Add export tests to x-pack/filebeat (elastic#20156) feat(ci): support building docker images for PRs (elastic#20323) Update system tests dependency (elastic#20287) [Libbeat] Log debug message if the Kibana dashboard can not be imported from the archive (elastic#12211) (elastic#20150) [Filebeat][Gsuite] Transform all dates to timestamp with processor (elastic#20308) Infer types in Prometheus remote_write (elastic#19944) Remove unnecessary restarts of metricsets while using Node autodiscover (elastic#19974) docs: update changelog on master branch (elastic#20259) feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282) [CI] Change upstream reference (elastic#20296) [Filebeat] Updates to Suricata module (elastic#20220) [docs] Fix Windows download link for agent (elastic#20258) [docs] Rename release highlights to what's new (elastic#20255) fix: update the display name of the multibranch job (elastic#20265) [Elastic Agent] Add basic protocol to control Elastic Agent. (elastic#20146) Cisco ASA: Fix message 106100 (elastic#20245) ...

…fig checks (elastic#20305)

…inished errors in autodiscover config checks (elastic#20338)

…inished errors in autodiscover config checks (elastic#20339) * [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks (elastic#20305) (cherry picked from commit 8d2bc1f) * Update CHANGELOG.next.asciidoc

Add retry logic for not_finished state errors

888968b

Signed-off-by: chrismark <chrismarkou92@gmail.com>

ChrsMark added bug review [zube]: In Review autodiscovery Team:Platforms Label for the Integrations - Platforms team labels Jul 29, 2020

ChrsMark requested review from jsoriano and exekias July 29, 2020 10:17

ChrsMark self-assigned this Jul 29, 2020

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 29, 2020

small fix

9c9e630

Signed-off-by: chrismark <chrismarkou92@gmail.com>

jsoriano added needs_backport PR is waiting to be backported to other branches. v7.10.0 v7.8.2 v7.9.0 labels Jul 29, 2020

Remove retry logic and ignore ErrInputNotFinished errors

52b5bd4

Signed-off-by: chrismark <chrismarkou92@gmail.com>

ChrsMark changed the title ~~[Autodiscovery] Add retry logic for not_finished state errors~~ [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks Jul 29, 2020

ChrsMark changed the title ~~[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks~~ [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks Jul 29, 2020

changelog

17393cb

Signed-off-by: chrismark <chrismarkou92@gmail.com>

jsoriano approved these changes Jul 29, 2020

View reviewed changes

libbeat/autodiscover/providers/kubernetes/pod.go Show resolved Hide resolved

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved

fix changelog

caf9e7e

Signed-off-by: chrismark <chrismarkou92@gmail.com>

jsoriano approved these changes Jul 29, 2020

View reviewed changes

fix comment

265b922

Signed-off-by: chrismark <chrismarkou92@gmail.com>

exekias suggested changes Jul 29, 2020

View reviewed changes

libbeat/common/errors.go Outdated Show resolved Hide resolved

Move location of errors.go from libeat to filebeat

ec3d014

Signed-off-by: chrismark <chrismarkou92@gmail.com>

exekias approved these changes Jul 29, 2020

View reviewed changes

Merge branch 'master' into fix_autodiscover_updates_issue

85be061

ChrsMark merged commit 7a34167 into elastic:master Jul 30, 2020

ChrsMark added a commit to ChrsMark/beats that referenced this pull request Jul 30, 2020

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover con…

23db800

…fig checks (elastic#20305) (cherry picked from commit 7a34167)

ChrsMark mentioned this pull request Jul 30, 2020

Cherry-pick #20305 to 7.x: [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20337

Merged

ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Jul 30, 2020

ChrsMark added a commit to ChrsMark/beats that referenced this pull request Jul 30, 2020

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover con…

9d8ab56

…fig checks (elastic#20305) (cherry picked from commit 7a34167)

This was referenced Jul 30, 2020

Cherry-pick #20305 to 7.9: [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20338

Merged

Cherry-pick #20305 to 7.8: [Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20339

Merged

ChrsMark added a commit to ChrsMark/beats that referenced this pull request Jul 30, 2020

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover con…

f913715

…fig checks (elastic#20305) (cherry picked from commit 7a34167)

ChrsMark added a commit that referenced this pull request Jul 30, 2020

Cherry-pick #20305 to 7.9: [Autodiscovery] Ignore ErrInputNotFinished…

0255c57

… errors in autodiscover config checks (#20338)

ChrsMark mentioned this pull request Jul 31, 2020

[autodiscover] Error creating runner from config: Can only start an input when all related states are finished #11834

Closed

This was referenced Sep 2, 2020

[Autodiscover] Handle input-not-finished errors in config reload #20915

Merged

Cherry-pick #20915 to 7.x: [Autodiscover] Handle input-not-finished errors in config reload #20928

Merged

melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover con…

f57ab92

…fig checks (elastic#20305)

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023

Cherry-pick elastic#20305 to 7.9: [Autodiscovery] Ignore ErrInputNotF…

4126aac

…inished errors in autodiscover config checks (elastic#20338)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20305

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20305

ChrsMark commented Jul 29, 2020 •

edited

Loading

elasticmachine commented Jul 29, 2020

elasticmachine commented Jul 29, 2020 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

jsoriano left a comment

exekias left a comment

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20305

[Autodiscovery] Ignore ErrInputNotFinished errors in autodiscover config checks #20305

Conversation

ChrsMark commented Jul 29, 2020 • edited Loading

What does this PR do?

Why is it important?

How to test this PR locally

elasticmachine commented Jul 29, 2020

elasticmachine commented Jul 29, 2020 • edited by jenkins-beats-ci bot Loading

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Steps errors

Log output

jsoriano left a comment

Choose a reason for hiding this comment

exekias left a comment

Choose a reason for hiding this comment

ChrsMark commented Jul 29, 2020 •

edited

Loading

elasticmachine commented Jul 29, 2020 •

edited by jenkins-beats-ci bot

Loading