Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pillow from testing requirements.txt #20407

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 3, 2020

What does this PR do?

Remove Pillow from requirements.txt.

Why is it important?

It contains deprecated code to support older versions of Python, and it doesn't seem to be used in Beats. I introduced it on the migration to Python 3 (#14798), not sure why.

Related issues

@jsoriano jsoriano added enhancement in progress Pull request is currently in progress. :Testing [zube]: In Progress Team:Integrations Label for the Integrations team labels Aug 3, 2020
@jsoriano jsoriano self-assigned this Aug 3, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 3, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20407 updated]

  • Start Time: 2020-08-04T17:59:46.818+0000

  • Duration: 68 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 17828
Skipped 1920
Total 19748

@jsoriano
Copy link
Member Author

jsoriano commented Aug 4, 2020

jenkins run the tests please

@jsoriano jsoriano marked this pull request as ready for review August 4, 2020 20:07
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@jsoriano jsoriano added [zube]: In Review needs_backport PR is waiting to be backported to other branches. review and removed [zube]: In Progress in progress Pull request is currently in progress. labels Aug 4, 2020
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Longer term it might be nice to have CI run something like pip-extra-reqs to make sure we keep our dependencies pruned at all times.

@jsoriano
Copy link
Member Author

jsoriano commented Aug 5, 2020

Longer term it might be nice to have CI run something like pip-extra-reqs to make sure we keep our dependencies pruned at all times.

Oh, great suggestion! I will give a try to this tool.

@jsoriano jsoriano merged commit 3cc97ff into elastic:master Aug 5, 2020
@jsoriano jsoriano deleted the remove-pillow branch August 5, 2020 10:16
@jsoriano jsoriano added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 5, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 5, 2020
jsoriano added a commit that referenced this pull request Aug 5, 2020
v1v added a commit to v1v/beats that referenced this pull request Aug 6, 2020
…ne-2.0

* upstream/master:
  [docs] Promote ingest management to beta (elastic#20295)
  Upgrade elasticsearch client library used in tests (elastic#20405)
  Disable logging when pulling on python integration tests (elastic#20397)
  Remove pillow from testing requirements.txt (elastic#20407)
  [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440)
  [Ingest Manager] Send datastreams fields (elastic#20402)
  Add event.ingested to all Filebeat modules (elastic#20386)
  [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426)
  Improve cgroup_regex docs with examples (elastic#20425)
  Makes `metrics` config option required in app_insights (elastic#20406)
  Ensure install scripts only install if needed (elastic#20349)
  Update container name for the azure filesets (elastic#19899)
  Group same timestamp metrics values in app_insights metricset (elastic#20403)
  add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767)
  Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547)
  [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396)
  Update Suricata dashboards (elastic#20394)
  [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359)
  Prepare home directories for docker images in a different stage (elastic#20356)
v1v added a commit to v1v/beats that referenced this pull request Aug 6, 2020
…allation

* upstream/master: (23 commits)
  [docs] Promote ingest management to beta (elastic#20295)
  Upgrade elasticsearch client library used in tests (elastic#20405)
  Disable logging when pulling on python integration tests (elastic#20397)
  Remove pillow from testing requirements.txt (elastic#20407)
  [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440)
  [Ingest Manager] Send datastreams fields (elastic#20402)
  Add event.ingested to all Filebeat modules (elastic#20386)
  [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426)
  Improve cgroup_regex docs with examples (elastic#20425)
  Makes `metrics` config option required in app_insights (elastic#20406)
  Ensure install scripts only install if needed (elastic#20349)
  Update container name for the azure filesets (elastic#19899)
  Group same timestamp metrics values in app_insights metricset (elastic#20403)
  add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767)
  Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547)
  [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396)
  Update Suricata dashboards (elastic#20394)
  [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359)
  Prepare home directories for docker images in a different stage (elastic#20356)
  New multiline mode in Filebeat: while_pattern (elastic#19662)
  ...
jsoriano added a commit that referenced this pull request Aug 10, 2020
Packages listed in current requirements.txt file cannot be installed in
python 3.5 and 3.9:
* Pillow doesn't have a candidate for 3.9, it was already removed
  in #20407, but added again by mistake in #16883.
* zipp package needed by pytest works with different versions depending
  on the version of python, version that works with python 3.5 doesn't work
  with other versions.
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Packages listed in current requirements.txt file cannot be installed in
python 3.5 and 3.9:
* Pillow doesn't have a candidate for 3.9, it was already removed
  in elastic#20407, but added again by mistake in elastic#16883.
* zipp package needed by pytest works with different versions depending
  on the version of python, version that works with python 3.5 doesn't work
  with other versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants