Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20403 to 7.9: Group same timestamp metrics values in app_insights metricset #20419

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Cherry-pick #20403 to 7.9: Group same timestamp metrics values in app_insights metricset #20419

merged 1 commit into from
Aug 4, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 4, 2020

Cherry-pick of PR #20403 to 7.9 branch. Original message:

What does this PR do?

  • groups same timestamp metric values
  • removes any nil values

Why is it important?

  • groups same timestamp metric values
  • removes any nil values
  • existing test should cover changes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Group same timestamp metrics values in app_insights metricset (elasti…
4b0b6b2 
…c#20403)

* mofidy doc

* work on data

* changelog

* mage fmt update

(cherry picked from commit b356494)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2020
@narph narph self-assigned this Aug 4, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Aug 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20419 opened]

  • Start Time: 2020-08-04T08:48:04.141+0000

  • Duration: 42 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 800
Skipped 72
Total 872

@narph narph merged commit cabf3ee into elastic:7.9 Aug 4, 2020
@narph narph deleted the backport_20403_7.9 branch August 4, 2020 09:56
@zube zube bot removed the [zube]: Done label Nov 2, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@narph
Group same timestamp metrics values in app_insights metricset (elasti…
fa1a612 
…c#20403) (elastic#20419)

* mofidy doc

* work on data

* changelog

* mage fmt update

(cherry picked from commit fe78a57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @ChrsMark