-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat][http_endpoint input] Adds support for custom auth header names and secret #20435
Merged
urso
merged 8 commits into
elastic:master
from
P1llus:filebeat_http_endpoint_headersecret
Aug 10, 2020
Merged
[Filebeat][http_endpoint input] Adds support for custom auth header names and secret #20435
urso
merged 8 commits into
elastic:master
from
P1llus:filebeat_http_endpoint_headersecret
Aug 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…required for certain modules like zoom
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Aug 4, 2020
10 tasks
andrewstucki
reviewed
Aug 4, 2020
Collaborator
I added the changes you requested @andrewstucki . I did not hardcode a header value though, as currently this does not have a "secret.enable true/false". So the config validation checks expects both to either be nil or both set to a value. |
Jenkins test this |
urso
reviewed
Aug 6, 2020
…point_headersecret
…us/beats into filebeat_http_endpoint_headersecret
urso
approved these changes
Aug 10, 2020
andrewstucki
approved these changes
Aug 10, 2020
8 tasks
urso
pushed a commit
to urso/beats
that referenced
this pull request
Aug 12, 2020
…ames and secret (elastic#20435) (cherry picked from commit d4fb2bc)
urso
pushed a commit
that referenced
this pull request
Aug 12, 2020
…rt for custom auth header names and secret (#20519) Co-authored-by: Marius Iversen <pillus@chasenet.org>
10 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Certain webhooks offers functionality to add a custom header and defined secret to each request to identify the source. This PR adds the possibility to configure the header name and secret that needs to be confirmed for every request, similar but not the same as basic auth.
Why is it important?
Required for certain modules like Zoom #20414
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
Added nosetest for wrong configuration option, ensuring that anything not matching header+secret is dropped and that a successful match allows the request with the correct responses.
Tested with: