Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarrify metricbeat must fetch data from all nodes #20441

Closed
wants to merge 1 commit into from
Closed

Clarrify metricbeat must fetch data from all nodes #20441

wants to merge 1 commit into from

Conversation

ebuildy
Copy link

@ebuildy ebuildy commented Aug 5, 2020

This is a very important point, and is missing.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is a very important point, and is missing.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 5, 2020
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

The PR is not allowed to run in the CI yet

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20441 opened]

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2020-08-05T08:23:20.416+0000

  • Duration: 5 min 44 sec

  • Commit: 9ebede1

Steps errors

Expand to view the steps failures

  • Name: Error signal
    • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-05T08:27:53.076+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-08-05T08:27:54.554Z] Stage "Build and Test" skipped due to earlier failure(s)
[2020-08-05T08:27:55.974Z] Stage "Elastic Agent x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:55.987Z] Stage "Elastic Agent x-pack Windows" skipped due to earlier failure(s)
[2020-08-05T08:27:55.999Z] Stage "Elastic Agent Mac OS X" skipped due to earlier failure(s)
[2020-08-05T08:27:56.010Z] Stage "Filebeat oss" skipped due to earlier failure(s)
[2020-08-05T08:27:56.021Z] Stage "Filebeat x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:56.033Z] Stage "Filebeat Mac OS X" skipped due to earlier failure(s)
[2020-08-05T08:27:56.044Z] Stage "Filebeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-08-05T08:27:56.054Z] Stage "Filebeat Windows" skipped due to earlier failure(s)
[2020-08-05T08:27:56.067Z] Stage "Filebeat x-pack Windows" skipped due to earlier failure(s)
[2020-08-05T08:27:56.078Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.084Z] Stage "Auditbeat oss Linux" skipped due to earlier failure(s)
[2020-08-05T08:27:56.096Z] Stage "Auditbeat crosscompile" skipped due to earlier failure(s)
[2020-08-05T08:27:56.107Z] Stage "Auditbeat oss Mac OS X" skipped due to earlier failure(s)
[2020-08-05T08:27:56.118Z] Stage "Auditbeat oss Windows" skipped due to earlier failure(s)
[2020-08-05T08:27:56.130Z] Stage "Auditbeat x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:56.142Z] Stage "Auditbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-08-05T08:27:56.154Z] Stage "Auditbeat x-pack Windows" skipped due to earlier failure(s)
[2020-08-05T08:27:56.166Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.172Z] Stage "Libbeat x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:56.184Z] Stage "Metricbeat OSS Unit tests" skipped due to earlier failure(s)
[2020-08-05T08:27:56.195Z] Stage "Metricbeat OSS Integration tests" skipped due to earlier failure(s)
[2020-08-05T08:27:56.206Z] Stage "Metricbeat Python integration tests" skipped due to earlier failure(s)
[2020-08-05T08:27:56.217Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:56.223Z] Stage "Metricbeat crosscompile" skipped due to earlier failure(s)
[2020-08-05T08:27:56.235Z] Stage "Metricbeat Mac OS X" skipped due to earlier failure(s)
[2020-08-05T08:27:56.246Z] Stage "Metricbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-08-05T08:27:56.258Z] Stage "Metricbeat Windows" skipped due to earlier failure(s)
[2020-08-05T08:27:56.270Z] Stage "Metricbeat x-pack Windows" skipped due to earlier failure(s)
[2020-08-05T08:27:56.283Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.289Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.295Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.301Z] Stage "Winlogbeat Windows x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:56.313Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.319Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.325Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-05T08:27:56.331Z] Stage "Kubernetes" skipped due to earlier failure(s)
[2020-08-05T08:27:56.532Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.542Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.552Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:56.561Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.570Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.580Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.590Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.599Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:56.608Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-05T08:27:57.786Z] Failed in branch Elastic Agent x-pack
[2020-08-05T08:27:57.795Z] Failed in branch Elastic Agent x-pack Windows
[2020-08-05T08:27:57.804Z] Failed in branch Elastic Agent Mac OS X
[2020-08-05T08:27:57.814Z] Failed in branch Filebeat oss
[2020-08-05T08:27:57.824Z] Failed in branch Filebeat x-pack
[2020-08-05T08:27:57.832Z] Failed in branch Filebeat Mac OS X
[2020-08-05T08:27:57.842Z] Failed in branch Filebeat x-pack Mac OS X
[2020-08-05T08:27:57.850Z] Failed in branch Filebeat Windows
[2020-08-05T08:27:57.860Z] Failed in branch Filebeat x-pack Windows
[2020-08-05T08:27:57.871Z] Failed in branch Auditbeat oss Linux
[2020-08-05T08:27:57.880Z] Failed in branch Auditbeat crosscompile
[2020-08-05T08:27:57.889Z] Failed in branch Auditbeat oss Mac OS X
[2020-08-05T08:27:57.899Z] Failed in branch Auditbeat oss Windows
[2020-08-05T08:27:57.909Z] Failed in branch Auditbeat x-pack
[2020-08-05T08:27:57.919Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-08-05T08:27:57.927Z] Failed in branch Auditbeat x-pack Windows
[2020-08-05T08:27:57.936Z] Failed in branch Libbeat x-pack
[2020-08-05T08:27:57.945Z] Failed in branch Metricbeat OSS Unit tests
[2020-08-05T08:27:57.954Z] Failed in branch Metricbeat OSS Integration tests
[2020-08-05T08:27:57.964Z] Failed in branch Metricbeat Python integration tests
[2020-08-05T08:27:57.973Z] Failed in branch Metricbeat crosscompile
[2020-08-05T08:27:57.982Z] Failed in branch Metricbeat Mac OS X
[2020-08-05T08:27:57.991Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-08-05T08:27:58.001Z] Failed in branch Metricbeat Windows
[2020-08-05T08:27:58.009Z] Failed in branch Metricbeat x-pack Windows
[2020-08-05T08:27:58.018Z] Failed in branch Winlogbeat Windows x-pack
[2020-08-05T08:27:58.027Z] Failed in branch Kubernetes
[2020-08-05T08:27:58.686Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:58.696Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:58.705Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-08-05T08:27:58.716Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:58.726Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:58.739Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-05T08:27:59.301Z] Failed in branch Packetbeat
[2020-08-05T08:27:59.309Z] Failed in branch dockerlogbeat
[2020-08-05T08:27:59.317Z] Failed in branch Journalbeat
[2020-08-05T08:27:59.869Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:59.880Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:59.891Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-08-05T08:27:59.901Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-05T08:28:00.015Z] Failed in branch Metricbeat x-pack
[2020-08-05T08:28:00.025Z] Failed in branch Winlogbeat
[2020-08-05T08:28:00.508Z] Failed in branch Heartbeat
[2020-08-05T08:28:00.518Z] Failed in branch Libbeat
[2020-08-05T08:28:00.528Z] Failed in branch Functionbeat
[2020-08-05T08:28:00.529Z] Stage "Generators" skipped due to earlier failure(s)
[2020-08-05T08:28:00.766Z] Failed in branch Generators
[2020-08-05T08:28:02.845Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20441
[2020-08-05T08:28:03.034Z] [INFO] getVaultSecret: Getting secrets
[2020-08-05T08:28:03.130Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-05T08:28:04.238Z] + chmod 755 generate-build-data.sh
[2020-08-05T08:28:04.238Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20441/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20441/runs/1 ABORTED 283551
[2020-08-05T08:28:04.238Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20441/runs/1/steps/?limit=10000 -o steps-info.json
[2020-08-05T08:28:04.788Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20441/runs/1/tests/?status=FAILED -o tests-errors.json

@andresrc andresrc added docs Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 9, 2020
@@ -5,7 +5,7 @@ This file is generated! See scripts/mage/docs_collector.go
[[metricbeat-module-elasticsearch]]
== Elasticsearch module

The `elasticsearch` module collects metrics about {es}.
The `elasticsearch` module collects metrics about {es}. In order to get all metricsets, you must install Metricbeat on each Elasticsearch node in the monitored cluster.
Copy link
Contributor

@ycombinator ycombinator Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite true. Metricbeat could be installed anywhere and this module's hosts settings could be configured to point to all nodes in an Elasticsearch cluster.

Also, recently we introduced a scope: cluster setting that let's users point this module to any node in the Elasticsearch cluster: #18547.

@ycombinator
Copy link
Contributor

Hi @ebuildy, thank you for your PR. We generally target PRs to master and then backport them to active release branches (7.x, 7.9, etc.). So could you please re-target this PR to the master branch? Also, please see the comment I left on the documentation change as well. Thanks again — we appreciate your contribution!

@dedemorton
Copy link
Contributor

Closing this PR because it's stalled, and it sounds like the content changes are not quite accurate. Please feel free to open a new PR if you want to submit other changes. (Tip: Change to the master branch in the docs before you click Edit.)

@dedemorton dedemorton closed this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants