Fix data loss on filebeat/winlogbeat shutdown #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2016 16:05
syncPublisher needs to check (publisher.Client).PublishEvents return code and stop if `false` is returned. Only in case of client.Close() is run while sending, `false` will be returned.
|
Closes #2041 |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filebeat/winlogbeat in master branch might loose data between restarts, due to non-published events still being forwarded to registry as success on shutdown.
syncPublisher needs to check (publisher.Client).PublishEvents return code and
stop if
falseis returned. Only in case of client.Close() is run whilesending,
falsewill be returned.