Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20420 to 7.9: Move to datastream instead of dataset #20482

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Cherry-pick #20420 to 7.9: Move to datastream instead of dataset #20482

merged 1 commit into from
Aug 6, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #20420 to 7.9 branch. Original message:

What does this PR do?

This PR moves away from dataset.* fields and uses datastream.* fields instead.
It also requires fleet to send configuration with new fields in inputs definition.

This PR includes config change on top of event decorators.

Why is it important?

elastic/integrations#213
elastic/elasticsearch#60592

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
1bc0e0b 
[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
@michalpristas michalpristas self-assigned this Aug 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 6, 2020
@michalpristas
Copy link
Contributor Author

Tested with elastic/kibana#74558
looks ok

blakerouse
blakerouse approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20482 opened]

  • Start Time: 2020-08-06T16:24:00.334+0000

  • Duration: 60 min 13 sec

@michalpristas michalpristas merged commit 65d488d into elastic:7.9 Aug 6, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@michalpristas
[Ingest Manager] Move to datastream instead of dataset (elastic#20420) (
7905f34 
elastic#20482)

[Ingest Manager] Move to datastream instead of dataset (elastic#20420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
backport Ingest Management:beta1 Group issues for ingest management beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @blakerouse