Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20386 to 7.x: Add event.ingested to all Filebeat modules #20483

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Aug 6, 2020

Cherry-pick of PR #20386 to 7.x branch. Original message:

What does this PR do?

The event.ingested field defines time at which the event was ingested to Elasticsearch
and it added by the Ingest Node pipeline.

This adds a test to ensure all modules create event.ingested.

Why is it important?

This field is important when trying to build
alerts for activities that may have been reported long after they occurred (@timestamp is
much older than event.ingested). This might happen if an agent was offline for a period
of time or the processing was delayed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Verify that no pipelines have duplicate set processors for event.ingested

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 6, 2020
The event.ingested field defines time at which the event was ingested to Elasticsearch
and it added by the Ingest Node pipeline. This field is important when trying to build
alerts for activities that may have been reported long after they occurred (@timestamp is
much older than event.ingested). This might happen if an agent was offline for a period
of time or the processing was delayed.

This adds a test to ensure all modules create event.ingested.

Use Filebeat read time instead of ingest time as event.created in Zeek.

Closes elastic#20073

(cherry picked from commit 829c3b7)
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20483 updated]

  • Start Time: 2020-08-11T11:12:48.680+0000

  • Duration: 67 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 5508
Skipped 824
Total 6332

@andrewkroh andrewkroh merged commit 9ebe21c into elastic:7.x Aug 11, 2020
@zube zube bot removed the [zube]: Done label Nov 10, 2020
@andrewkroh andrewkroh deleted the backport_20386_7.x branch January 14, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants