Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat] clone value when copy fields in processors #20500

Merged
merged 1 commit into from
Aug 19, 2020
Merged

[filebeat] clone value when copy fields in processors #20500

merged 1 commit into from
Aug 19, 2020

Conversation

ianwoolf
Copy link
Contributor

@ianwoolf ianwoolf commented Aug 7, 2020

  • Bug

fix the bug mentioned in #19206

What does this PR do?

clone value when copy field in processors to avoid crash.

Why is it important?

As explained in #19206, a child-document of a map may point to it's root without deep copy.

Related issues

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 7, 2020
@cla-checker-service
Copy link

cla-checker-service bot commented Aug 7, 2020 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 7, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [kvch commented: jenkins run tests]

  • Start Time: 2020-08-17T11:22:40.475+0000

  • Duration: 76 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 14613
Skipped 1307
Total 15920

Steps errors

Expand to view the steps failures

  • Name: Install Go 1.14.7

    • Description: .ci/scripts/install-go.sh

    • Duration: 2 min 7 sec

    • Start Time: 2020-08-17T11:47:31.988+0000

    • log

@ianwoolf ianwoolf force-pushed the pr-clone-value-when-copy_fields-in-processors branch from a07e16e to bc4c66a Compare August 9, 2020 03:56
@ianwoolf ianwoolf changed the title clone value when copy fields in processors [filebeat] clone value when copy fields in processors Aug 9, 2020
@ianwoolf ianwoolf force-pushed the pr-clone-value-when-copy_fields-in-processors branch from bc4c66a to 29a9340 Compare August 9, 2020 05:21
@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Aug 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 9, 2020
@ianwoolf ianwoolf force-pushed the pr-clone-value-when-copy_fields-in-processors branch from 29a9340 to 8c69f44 Compare August 9, 2020 07:22
@ianwoolf
Copy link
Contributor Author

ianwoolf commented Aug 9, 2020

the travis-ci fail, the job log report error The job exceeded the maximum time limit for jobs, and has been terminated. I try many times. How can i fix it

@ianwoolf ianwoolf force-pushed the pr-clone-value-when-copy_fields-in-processors branch 2 times, most recently from 78733b0 to 0851406 Compare August 10, 2020 02:45
@kvch
Copy link
Contributor

kvch commented Aug 11, 2020

Could you please add an entry to the changelog.next.asciidoc file?

@kvch
Copy link
Contributor

kvch commented Aug 11, 2020

jenkins run tests

@kvch kvch self-assigned this Aug 11, 2020
@kvch kvch added the needs_backport PR is waiting to be backported to other branches. label Aug 11, 2020
@ianwoolf ianwoolf force-pushed the pr-clone-value-when-copy_fields-in-processors branch 3 times, most recently from 635f1e5 to ca29891 Compare August 15, 2020 07:22
@ianwoolf ianwoolf force-pushed the pr-clone-value-when-copy_fields-in-processors branch from ca29891 to da93ae0 Compare August 16, 2020 23:10
@ianwoolf
Copy link
Contributor Author

i add an entry to the changelog.next.asciidoc file.

@kvch
Copy link
Contributor

kvch commented Aug 17, 2020

jenkins run tests

@ianwoolf
Copy link
Contributor Author

ianwoolf commented Aug 18, 2020 •
edited
Loading

I have failed in travis-ci. There are the following errors

  Building wheel for pyrsistent (setup.py) ... error
  ERROR: Command errored out with exit status 1:

what can i do to fix it?

@kvch kvch merged commit 0940e25 into elastic:master Aug 19, 2020
@kvch
Copy link
Contributor

kvch commented Aug 19, 2020

@ianwoolf Thank you for your contribution!

@ianwoolf ianwoolf deleted the pr-clone-value-when-copy_fields-in-processors branch August 20, 2020 09:38
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@ianwoolf @melchiormoulin
Clone value when copy fields in processors to avoid crash (elastic#20500
99f3c42 
)

Closes elastic#19206
@frconil frconil added needs_backport PR is waiting to be backported to other branches. and removed needs_backport PR is waiting to be backported to other branches. labels Jun 21, 2021
@jsoriano jsoriano mentioned this pull request Jun 21, 2021
Merged
@jsoriano jsoriano added v7.14.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 21, 2021
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Jun 21, 2021
@ianwoolf @jsoriano
Clone value when copy fields in processors to avoid crash (elastic#20500
854acce 
)

Closes elastic#19206

(cherry picked from commit 0940e25)
@jsoriano jsoriano mentioned this pull request Jun 21, 2021
Merged
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Jun 21, 2021
@ianwoolf @jsoriano
Clone value when copy fields in processors to avoid crash (elastic#20500
3eba5e3 
)

Closes elastic#19206

(cherry picked from commit 0940e25)
jsoriano added a commit that referenced this pull request Jun 21, 2021
@jsoriano @ianwoolf
Clone value when copy fields in processors to avoid crash (#20500) (#…
56a909e 
…26381)

(cherry picked from commit 0940e25)

Co-authored-by: ian woolf <btw515wolf2@gmail.com>
jsoriano added a commit that referenced this pull request Jun 22, 2021
@jsoriano @ianwoolf
Clone value when copy fields in processors to avoid crash (#20500) (#…
51c97b9 
…26382)

Closes #19206

(cherry picked from commit 0940e25)

Co-authored-by: ian woolf <btw515wolf2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees

@kvch kvch

Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.13.3 v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ianwoolf @elasticmachine @kvch @jsoriano @andresrc @frconil