Cherry-pick #18704 to 7.x: Fix byte counters for source/destination/server/client #20530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PANW firewalls expone why a session is ended (endreason). Currenlty it's not tracked. End reason is important to track down why a specific session is ended (timeout, rst from client/server...). This adds panw.panos.endreason. Co-authored-by: Andrea Dainese <andrea.dainese@gmail.com> Co-authored-by: Adrian Serrano <adrisr83@gmail.com> (cherry picked from commit 6c0c3bf)
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18704 to 7.x branch. Original message:
What does this PR do?
The original code mixes source/destination/server/client for byte counters.
Original:
client.bytes: 32
destination.bytes: 32
server.bytes: 33
source.bytes: 33
But client is source, not destination.
Fix is:
client.bytes: 32
source.bytes: 32
server.bytes: 33
destination.bytes: 33
Why is it important?
Because with original code source and destination counters are wrong.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.