Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event.category network_traffic from Packetbeat #20556

Conversation

andrewkroh
Copy link
Member

What does this PR do?

network_traffic is not a valid ECS event.category value so remove it from all Packetbeat events.

Why is it important?

Beats should follow the Elastic Common Schema.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 11, 2020
network_traffic is not a valid ECS event.category value so remove it from all Packetbeat events.
@andrewkroh andrewkroh force-pushed the feature/pb/remove-network-traffic-category branch from e32dee4 to 79e8058 Compare August 11, 2020 14:31
@andrewkroh andrewkroh marked this pull request as ready for review August 11, 2020 14:31
@andrewkroh andrewkroh requested a review from a team as a code owner August 11, 2020 14:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20556 updated]

  • Start Time: 2020-08-11T20:00:23.265+0000

  • Duration: 61 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 1586
Skipped 27
Total 1613

@andrewkroh
Copy link
Member Author

run tests

@andrewkroh andrewkroh force-pushed the feature/pb/remove-network-traffic-category branch from 4fdee88 to 79e8058 Compare August 11, 2020 19:59
@andrewkroh andrewkroh merged commit 6244316 into elastic:master Aug 14, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
network_traffic is not a valid ECS event.category value so remove it from all Packetbeat events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants