-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #20549 #20566 and #20242 to 7.x: [Heartbeat] Add Magefile to X-Pack #20638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use drop path * changelog
…c#20186) [Ingest Manager] Prepare packaging for endpoint and asc files (elastic#20186)
This also restructures the main magefile to share code with the x-pack one (cherry picked from commit d036955)
andrewvc
added
[zube]: In Review
backport
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
labels
Aug 17, 2020
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 17, 2020
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 17, 2020
* Heartbeat packaging fixes There were a few issues with the package target for x-pack/heartbeat. * There are no integTests setup in x-pack/heartbeat * Add make files
andrewvc
changed the title
Cherry-pick #20549 to 7.x: [Heartbeat] Add Magefile to X-Pack
Cherry-pick #20549,#20566 to 7.x: [Heartbeat] Add Magefile to X-Pack
Aug 17, 2020
zube
bot
changed the title
Cherry-pick #20549,#20566 to 7.x: [Heartbeat] Add Magefile to X-Pack
Cherry-pick #20549 to 7.x: [Heartbeat] Add Magefile to X-Pack
Aug 17, 2020
zube
bot
added
[zube]: In Review
[zube]: Inbox
and removed
[zube]: Inbox
[zube]: In Review
labels
Aug 17, 2020
andrewvc
changed the title
Cherry-pick #20549 to 7.x: [Heartbeat] Add Magefile to X-Pack
Cherry-pick #20549 and 20566 to 7.x: [Heartbeat] Add Magefile to X-Pack
Aug 17, 2020
zube
bot
changed the title
Cherry-pick #20549 and 20566 to 7.x: [Heartbeat] Add Magefile to X-Pack
Cherry-pick #20549 to 7.x: [Heartbeat] Add Magefile to X-Pack
Aug 17, 2020
zube
bot
added
[zube]: In Review
[zube]: Inbox
and removed
[zube]: Inbox
[zube]: In Review
labels
Aug 17, 2020
Collaborator
andrewvc
changed the title
Cherry-pick #20549 to 7.x: [Heartbeat] Add Magefile to X-Pack
Cherry-pick #20549 #20566 to 7.x: [Heartbeat] Add Magefile to X-Pack
Aug 17, 2020
/package |
jsoriano
approved these changes
Aug 17, 2020
andrewvc
changed the title
Cherry-pick #20549 #20566 to 7.x: [Heartbeat] Add Magefile to X-Pack
Cherry-pick #20549 #20566 and #20242 to 7.x: [Heartbeat] Add Magefile to X-Pack
Aug 17, 2020
/package |
andrewkroh
approved these changes
Aug 17, 2020
/package |
jenkins run the tests please |
/package |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20549, #20566, and #20242 to 7.x branch. Original message:
There were a few issues with the package target for x-pack/heartbeat.
Update root Makefile to build packages for x-pack/heartbeat.
Update packaging CI job.
Magefile fixes (mostly with where the packaging spec was looking for files).
This also restructures the main magefile to share code with the x-pack.
This fixes the broken agent build which is trying to run
mage build
in the x-pack heartbeat folder.