Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20391 to 7.x: Add host inventory metrics to googlecloud compute metricset #20724

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Cherry-pick #20391 to 7.x: Add host inventory metrics to googlecloud compute metricset #20724

merged 2 commits into from
Aug 24, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 20, 2020

Cherry-pick of PR #20391 to 7.x branch. Original message:

What does this PR do?

Why is it important?

This PR is to add proposed host common fields into compute metricset:

  • host.id
  • host.name
  • host.cpu.pct
  • host.network.in.bytes
  • host.network.in.packets
  • host.network.out.bytes
  • host.network.out.packets
  • host.disk.read.bytes
  • host.disk.write.bytes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Start Metricbeat googlecloud module: ./metricbeat modules enable googlecloud
  2. Edit modules.d/googlecloud.yml to only include compute metricset:
- module: googlecloud
  metricsets:
    - compute
  region: "us-east1"
  project_id: elastic-observability
  credentials_file_path: "/Users/kaiyansheng/Downloads/elastic-observability-d17781618202.json"
  exclude_labels: false
  period: 300s

3.Change add_host_metadata processor config in metricbeat.yml file:

processors:
  - add_host_metadata:
      replace_fields: false
  1. Start metricbeat
  2. You should see metrics from compute metricset and includes fields listed above.

* Add host inventory metrics to googlecloud compute metricset

(cherry picked from commit cbb2f37)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Aug 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 20, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 20, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20724 updated]

  • Start Time: 2020-08-21T13:56:55.681+0000

  • Duration: 54 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 843
Skipped 72
Total 915

@kaiyan-sheng kaiyan-sheng merged commit 2ce5481 into elastic:7.x Aug 24, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_20391_7.x branch August 24, 2020 12:44
@zube zube bot removed the [zube]: Done label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants