Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20766 to 7.x: Request prometheus endpoints to be gzipped by default #20795

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Aug 26, 2020

Cherry-pick of PR #20766 to 7.x branch. Original message:

  • Enhancement

What does this PR do?

This PR ensures that we add gzip content type to all prometheus endpoint poll requests.

Why is it important?

This improves performance network performance as most of the payload of exposition format compresses really well.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

* Request prometheus endpoints to be gzipped by default

(cherry picked from commit fbaeefe)
@exekias exekias added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Aug 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 26, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20795 opened]

  • Start Time: 2020-08-26T09:30:19.946+0000

  • Duration: 72 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 3678
Skipped 810
Total 4488

@exekias exekias merged commit 3cb7839 into elastic:7.x Aug 27, 2020
@zube zube bot removed the [zube]: Done label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants