Add timestamp formatting to EventStringFormatter #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
enhancement
review
libbeat
in progress
urso
force-pushed
the
enh/fmtstr-with-timestamps
branch
from
c27f78e to
74ecefb
Compare
urso
added
review
and removed
in progress
This was referenced Jul 22, 2016
|
We will need this for |
|
yes. I want similar formatting support as logstash for |
| {mkDate(2015, 1, 1), "xx.w.E", "15.1.Thu"}, | ||
| {mkDate(2014, 12, 31), "xx.w.E", "15.1.Wed"}, | ||
| {mkDate(2015, 1, 1), "xx.w.EEEE", "15.1.Thursday"}, | ||
| {mkDate(2014, 12, 31), "xx.w.EEEE", "15.1.Wednesday"}, |
There was a problem hiding this comment.
Maybe also add a test with xxxx.ww which is the format recommended by the Logstash docs.
added 2 commits
July 25, 2016 15:55
Add date formatter to libbeat/common/dtfmt. Pattern syntax supported is subset of joda DateTimeFormat
urso
force-pushed
the
enh/fmtstr-with-timestamps
branch
from
74ecefb to
33d06a6
Compare
|
Amazing work, @urso! This code is actually a lot cleaner than the stdlib formatter. 👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add date formatter to libbeat/common/dtfmt. Pattern syntax supported
is subset of joda DateTimeFormat