Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat][zeek] Add mappings for x509 fields in kerberos #20958

Merged
merged 3 commits into from
Sep 4, 2020
Merged

[Filebeat][zeek] Add mappings for x509 fields in kerberos #20958

merged 3 commits into from
Sep 4, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 3, 2020

What does this PR do?

Adds mappings for the new x509 ecs fields in kebreros zeek module

Why is it important?

To keep our modules up to date with ecs 1.6.0

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files

  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 3, 2020
@marc-gr marc-gr requested a review from a team September 3, 2020 11:22
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 3, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20958 updated]

  • Start Time: 2020-09-03T11:23:03.497+0000

  • Duration: 52 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 2474
Skipped 388
Total 2862

leehinman
leehinman approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit de5a419 into elastic:master Sep 4, 2020
@marc-gr marc-gr deleted the zeek_kerberos_x509 branch September 4, 2020 06:50
marc-gr added a commit to marc-gr/beats that referenced this pull request Sep 4, 2020
@marc-gr
[Filebeat][zeek] Add mappings for x509 fields in kerberos (elastic#20958
de7936a 
)

* Add mappings for x509 fields in kerberos

* Add changelog entry

* Do gsub in place

(cherry picked from commit de5a419)
@marc-gr marc-gr mentioned this pull request Sep 4, 2020
Merged
2 tasks
@marc-gr marc-gr added the v7.10.0 label Sep 4, 2020
marc-gr added a commit that referenced this pull request Sep 4, 2020
@marc-gr
[Filebeat][zeek] Add mappings for x509 fields in kerberos (#20958) (#…
5b89c85 
…20975)

* Add mappings for x509 fields in kerberos

* Add changelog entry

* Do gsub in place

(cherry picked from commit de5a419)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@marc-gr @melchiormoulin
[Filebeat][zeek] Add mappings for x509 fields in kerberos (elastic#20958
cbd3757 
)

* Add mappings for x509 fields in kerberos

* Add changelog entry

* Do gsub in place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
ecs enhancement Filebeat Filebeat review v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @leehinman