Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21071 to 7.x: Handling missing counters in application_pool metricset #21133

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Cherry-pick #21071 to 7.x: Handling missing counters in application_pool metricset #21133

merged 1 commit into from
Sep 17, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Sep 17, 2020

Cherry-pick of PR #21071 to 7.x branch. Original message:

What does this PR do?

Mhe missing performance counters in the application_pool metricset would trigger an error and stop it.

Why is it important?

There should only be an error message if this is the case but should not stop the metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph
Handling missing counters in application_pool metricset (elastic#21071)
122241a 
* mofidy doc

* fix

* changelog

(cherry picked from commit bdfff66)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2020
@narph narph self-assigned this Sep 17, 2020
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Sep 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21133 opened]

  • Start Time: 2020-09-17T12:21:31.393+0000

  • Duration: 55 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 837
Skipped 72
Total 909

@narph narph merged commit db11ee7 into elastic:7.x Sep 17, 2020
@narph narph deleted the backport_21071_7.x branch September 17, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @ChrsMark