Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21155 to 7.x: [Filebeat] sync with recent changes in zeek package #21181

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Cherry-pick #21155 to 7.x: [Filebeat] sync with recent changes in zeek package #21181

merged 1 commit into from
Sep 28, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Sep 18, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21155 to 7.x branch. Original message:

What does this PR do?

Syncs changes made in zeek package with zeek module

  • always attempt community_id processor
  • dnp3 reorder pipeline to be same as package

Why is it important?

Filebeat module and package should be the same.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=zeek mage -v pythonIntegTest

@leehinman
sync with recent changes in zeek package (elastic#21155)
79bc69a 
- always attempt community_id processor
- dnp3 reorder pipeline to be same as package

(cherry picked from commit 1932f9f)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 18, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21181 opened]

  • Start Time: 2020-09-18T20:13:58.153+0000

  • Duration: 55 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 2485
Skipped 388
Total 2873

@leehinman leehinman merged commit 1c94c6d into elastic:7.x Sep 28, 2020
@leehinman leehinman deleted the backport_21155_7.x branch October 5, 2020 19:06
@zube zube bot removed the [zube]: Done label Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leehinman @elasticmachine @marc-gr