-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make beats module work for Stack Monitoring without xpack.enabled flag #21272
Make beats module work for Stack Monitoring without xpack.enabled flag #21272
Conversation
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errorsExpand to view the tests failures> Show only the first 10 test failures
|
Test | Results |
---|---|
Failed | 27 |
Passed | 8346 |
Skipped | 581 |
Total | 8954 |
Pinging @elastic/stack-monitoring (Stack monitoring) |
Pinging @elastic/integrations-services (Team:Services) |
We actually don't use this dataset within the Stack Monitoring UI directly; however, it is used by the telemetry code, but I'm unable to fully test that until the Maybe we should create a single PR with both |
Sounds good! I'll close both and open the feature branch with their contents. |
…eature/mb/elasticsearch/beats_state_xpack_flag
…csearch/beats_state_xpack_flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing a lot of new fields being included in the event that weren't there before. I would suggest removing these until we need them. It's easy to add new fields later rather than remove them once they are part of the public API.
Also, shouldn't there be a module-level fields.yml
that creates field aliases like we have in other Stack Monitoring modules' PRs?
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errorsExpand to view the tests failures> Show only the first 10 test failures
|
Test | Results |
---|---|
Failed | 35 |
Passed | 7882 |
Skipped | 519 |
Total | 8436 |
Ready to test in Kibana.
data.json
is included to help troubleshooting and it has been generating testing the Metricbeat binary directly with Elasticsearch.Both metricsets from Beats module are included in this PR