-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update generate_fields_docs.py #21359
Conversation
if beat_title == "Apm-Server": | ||
if "overwrite" in field: | ||
# And it's not a Kubernetes field | ||
if re.match("^kubernetes.*", field["field_path"]) is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubernetes.*
fields had to be excluded here as they're not ECS fields, but APM marks them as overwrite:true
.
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Pinging @elastic/obs-docs (Team:Docs) |
Pinging @elastic/integrations-services (Team:Services) |
1e1e663
to
b3a4d98
Compare
Sorry for the errant pings Automation and Ingest management; I accidentally pushed a few extra commits. |
b3a4d98
to
53e8a6a
Compare
Do I need to run another command for this to pass ci? Not sure what I'm doing wrong. |
jenkins run the tests |
1 similar comment
jenkins run the tests |
@bmorelli25 you can go ahead the failing test are broken in the master branch |
|
||
This section defines Elastic Common Schema (ECS) fields—a common set of fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to call out that ECS is an open source specification? Otherwise, it LGMT!
# Conflicts: # filebeat/docs/fields.asciidoc
* upstream/master: [CI] Setup git config globally (elastic#21562) docs: update generate_fields_docs.py (elastic#21359) Add support for additional fields from V2 ALB logs (elastic#21540) Move Prometheus query & remote_write to GA (elastic#21507) feat: add a new step to run the e2e tests for certain parts of Beats (elastic#21100) [Elastic Agent] Add elastic agent ID and version to events from filebeat and metricbeat. (elastic#21543) Release cloudfoundry input and processor as GA (elastic#21525) [Packetbeat] New SIP protocol (elastic#21221) [Filebeat][New Module] Add support for Microsoft MTP / 365 Defender (elastic#21446) [Beats][pytest] Asserting if filebeat logs include errors (elastic#20999) junipersrx-module initial release (elastic#20017) Add a persistent cache for cloudfoundry metadata based on badger (elastic#20775) Add missing changelog entry for cisco umbrella (elastic#21550) [Elastic Agent] Add upgrade CLI to initiate upgrade of Agent locally (elastic#21425) Enable filestream input (elastic#21533) Add filestream input reader (elastic#21481) [CI] fix 'no matches found within 10000' (elastic#21466) Fix billing.go aws.GetStartTimeEndTime (elastic#21531)
Summary
This PR updates
generate_fields_docs.py
:overwrite
.Tested with APM Server by running:
ECS description (all Beats)
APM Server ECS fields
Related PRs
For elastic/apm#276.
Relates to #20729.
The fine print
Sorry that my Python sucks 😓