-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make elasticsearch/shard metricset work for Stack Monitoring without xpack.enabled flag #21389
Make elasticsearch/shard metricset work for Stack Monitoring without xpack.enabled flag #21389
Conversation
Pinging @elastic/stack-monitoring (Stack monitoring) |
Pinging @elastic/integrations-services (Team:Services) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Test | Results |
---|---|
Failed | 0 |
Passed | 2312 |
Skipped | 532 |
Total | 2844 |
Not sure if I understand. In the mapping it is called I don't mind to change it, I just don't know where to change it 😄 |
I don't really know how the code works, but when I run the
I see:
|
Ok, thanks for explaining. I think I understand what the problem is. If I understood it correctly, I see 2 options:
Maybe @ycombinator has something to add too. In general, no root |
Re: the The problem, of course, is that in the case of the To solve this issue in this PR but also in general, I like this idea:
This would mean:
@sayden @chrisronline WDYT? |
Would it be easier if the UI code could just adapt to the documents being either |
If that's not difficult to do in the UI then sure! Also, before you do that, we should probably check all Stack Monitoring metricsets to see where else you might need to play this game. And then check how easy those would be to adapt in the UI as well. @sayden can you come up this information — basically the value of |
I can already tell you this will be easy. We can easily adapt https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/server/lib/create_query.js#L59 to support an array, just like we do now with |
@chrisronline thanks for the link. I understand now — you'll just add more clauses to the Assuming all of the above checks out, I think the impact on this PR is a noop. That is, Metricbeat can keep sending |
AFAIK, the telemetry code only concerns itself with
These should be going away in 7.11, with the ES team providing an API to permanently remove and disable the creation of new ones. However, we currently do not have a cluster alert that looks at this document type. I'll work on the Kibana PR to handle both |
One question - should I be seeing alias fields for this? I don't see anything setup for |
Yes, I will also add an alias for this one, sorry for the delay! |
"source_node": { | ||
"name": "1fb2aa83efac", | ||
"uuid": "hx-oJ1-aT_-5pRG22JMI1Q" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see the source_node.*
fields mentioned in the metricset's fields.yml
. Should they be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I completely forgot that I have to deactivate the test to check if all fields were documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment/question about fields potentially needing to be defined in the metricset's fields.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…csearch/shard_xpack_flag # Conflicts: # metricbeat/module/elasticsearch/fields.go # metricbeat/module/elasticsearch/ml_job/data.go
…xpack.enabled flag (elastic#21389)
Shard metricset maintains most of the Xpack flag functionality (indexing by the hash id created in the event) but includes now non-xpack things too.