-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #20005 to 7.x: Migrate S3 Input to Filebeat Input V2 #21500
Conversation
*moving s3 input to v2 input API Co-authored-by: urso <steffen.siering@elastic.co> (cherry picked from commit 7e36f5c)
Pinging @elastic/integrations-platforms (Team:Platforms) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-pick of PR #20005 to 7.x branch. Original message:
Note: This PR is based on #19756 to finish migrating s3 input to use Filebeat input V2.
What does this PR do?
Move s3 input to input v2 API.
This change splits the internal s3Input into s3Input and s3Collector. The s3Input is responsible for configuration only.
The unit tests have been modified, but the integration tests need some more work.
Why is it important?
Update to v2 input API.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Manual testing:
s3:ObjectCreated:*
type to your Amazon SQS queue.