Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21461 to 7.x: Send updating state #21530

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #21461 to 7.x branch. Original message:

What does this PR do?

This PR reports updating state of application after update process is started and error in case it is finished with failure

Tested with elastic/kibana#78810 after suggested changes (i did them manually) i started agent without starting a file server so UPDATE fails i got this (as expected)

image

UPDATE is ACK-ed and Error there is reported, under ACK there is line saying STATE was switched to UPDATING
image

after i started server and rekicked UPDATE action

image

update was ACKed and state switched to RUNNING after it finished.

Status on list page was ONLINE then UPDATING and then back ONLINE. Even though there were errors, so i guess this will be an object of next iteration.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 5, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21530 opened]

  • Start Time: 2020-10-05T15:37:19.203+0000

  • Duration: 37 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 4
Total 1388

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit b20c96c into elastic:7.x Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement Ingest Management:beta2 Group issues for ingest management beta2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants