Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip publisher flaky tests #21657

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Skip publisher flaky tests #21657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d79b036
Skip goroutines checker in TestOutputReload
jsoriano Oct 7, 2020
ff1856d
Skip TestReplaceClientWorker
jsoriano Oct 7, 2020
92a4122
mage fmt
jsoriano Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libbeat/publisher/pipeline/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ import (
"github.com/elastic/beats/v7/libbeat/publisher"
"github.com/elastic/beats/v7/libbeat/publisher/queue"
"github.com/elastic/beats/v7/libbeat/publisher/queue/memqueue"
"github.com/elastic/beats/v7/libbeat/tests/resources"

//"github.com/elastic/beats/v7/libbeat/tests/resources"

"github.com/stretchr/testify/require"
)
Expand All @@ -46,8 +47,9 @@ func TestOutputReload(t *testing.T) {
t.Run(name, func(t *testing.T) {
testutil.SeedPRNG(t)

goroutines := resources.NewGoroutinesChecker()
defer goroutines.Check(t)
// Flaky check: https://github.com/elastic/beats/issues/21656
//goroutines := resources.NewGoroutinesChecker()
//defer goroutines.Check(t)

err := quick.Check(func(q uint) bool {
numEventsToPublish := 15000 + (q % 500) // 15000 to 19999
Expand Down
2 changes: 2 additions & 0 deletions libbeat/publisher/pipeline/output_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ func TestMakeClientWorker(t *testing.T) {
}

func TestReplaceClientWorker(t *testing.T) {
t.Skip("Flaky test: https://github.com/elastic/beats/issues/17965")

tests := map[string]func(mockPublishFn) outputs.Client{
"client": newMockClient,
"network_client": newMockNetworkClient,
Expand Down