Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21754 to 7.10: Disable writes sync in persistent cache #21789

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Cherry-pick #21754 to 7.10: Disable writes sync in persistent cache #21789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions x-pack/libbeat/persistentcache/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@ func newStore(logger *logp.Logger, dir, name string) (*Store, error) {
// Opinionated options for the use of badger as a store for metadata caches in Beats.
options := badger.DefaultOptions(dbPath)
options.Logger = badgerLogger{logger.Named("badger")}
// TODO: Disabling sync writes gives better performance, and data loss wouldn't
// be a problem for caches. But we are not properly closing processors yet, so let
// sync on writes by now.
// options.SyncWrites = false
options.SyncWrites = false

db, err := badger.Open(options)
if err != nil {
Expand Down