Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shared-autodiscover.asciidoc #21827

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Update shared-autodiscover.asciidoc #21827

merged 1 commit into from
Oct 27, 2020

Conversation

newly12
Copy link
Contributor

@newly12 newly12 commented Oct 15, 2020

add descriptions for default values of labels.dedot and annotations.dedot, it helps user to understand the default behavior without looking into the code.

@newly12
Update shared-autodiscover.asciidoc
9d1f9c0 
add descriptions for default values of `labels.dedot` and `annotations.dedot`
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2020
@newly12 newly12 mentioned this pull request Oct 15, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 15, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user kaiyan-sheng, Replayed #1]

  • Start Time: 2020-10-27T16:23:35.888+0000

  • Duration: 24 min 59 sec

@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Oct 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 15, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 27, 2020
kaiyan-sheng
kaiyan-sheng approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@kaiyan-sheng kaiyan-sheng merged commit 601c323 into elastic:master Oct 27, 2020
@kaiyan-sheng kaiyan-sheng added the needs_backport PR is waiting to be backported to other branches. label Oct 27, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 27, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 27, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 27, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request Oct 27, 2020
@kaiyan-sheng @newly12
Update shared-autodiscover.asciidoc (#21827) (#22203)
47404b1 
add descriptions for default values of `labels.dedot` and `annotations.dedot`

(cherry picked from commit 601c323)

Co-authored-by: Peter Deng <newly.deng@gmail.com>
kaiyan-sheng added a commit that referenced this pull request Oct 27, 2020
@kaiyan-sheng @newly12
Update shared-autodiscover.asciidoc (#21827) (#22202)
cd565c2 
add descriptions for default values of `labels.dedot` and `annotations.dedot`

(cherry picked from commit 601c323)

Co-authored-by: Peter Deng <newly.deng@gmail.com>
v1v added a commit to v1v/beats that referenced this pull request Oct 29, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-64
3f9b862 
* upstream/master: (93 commits)
  Update commands used in the quick start (elastic#22248)
  Add interval documentation to `monitor` metricset (elastic#22152)
  [CI] enable x-pack/packetbeat in the CI (elastic#22252)
  Fix awscloudwatch input documentation (elastic#22247)
  Add support for different Azure Cloud environments in the metricbeat azure module (elastic#21044)
  [CI] support windows-2008-r2 (elastic#19791)
  protect against accessing undefined variables in sysmon module (elastic#22236)
  [CI] archive only if failed steps (elastic#22220)
  Add pe fields to Sysmon module (elastic#22217)
  [CI][flaky] Support 7.x branches and PRs (elastic#22197)
  Perfmon - Fix regular expressions to comply to multiple parentheses in instance name and object (elastic#22146)
  ci: improve linting speed (elastic#22103)
  Move cloudfoundry tags with metadata to common metadata fields (elastic#22150)
  [Docs] Update custom beat docs (elastic#22194)
  [Ingest Manager] Agent fix snapshot download for upgrade (elastic#22175)
  Update shared-autodiscover.asciidoc (elastic#21827)
  [DOCS] Warn about compression and Azure Event Hub for Kafka (elastic#21578)
  [CI][flaky] reporting for PRs in GitHub (elastic#21853)
  [Packetbeat] Create x-pack magefile (elastic#21979)
  [Elastic Agent] Fix deb/rpm installation (elastic#22153)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 29, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-32
a776d4d 
* upstream/master: (93 commits)
  Update commands used in the quick start (elastic#22248)
  Add interval documentation to `monitor` metricset (elastic#22152)
  [CI] enable x-pack/packetbeat in the CI (elastic#22252)
  Fix awscloudwatch input documentation (elastic#22247)
  Add support for different Azure Cloud environments in the metricbeat azure module (elastic#21044)
  [CI] support windows-2008-r2 (elastic#19791)
  protect against accessing undefined variables in sysmon module (elastic#22236)
  [CI] archive only if failed steps (elastic#22220)
  Add pe fields to Sysmon module (elastic#22217)
  [CI][flaky] Support 7.x branches and PRs (elastic#22197)
  Perfmon - Fix regular expressions to comply to multiple parentheses in instance name and object (elastic#22146)
  ci: improve linting speed (elastic#22103)
  Move cloudfoundry tags with metadata to common metadata fields (elastic#22150)
  [Docs] Update custom beat docs (elastic#22194)
  [Ingest Manager] Agent fix snapshot download for upgrade (elastic#22175)
  Update shared-autodiscover.asciidoc (elastic#21827)
  [DOCS] Warn about compression and Azure Event Hub for Kafka (elastic#21578)
  [CI][flaky] reporting for PRs in GitHub (elastic#21853)
  [Packetbeat] Create x-pack magefile (elastic#21979)
  [Elastic Agent] Fix deb/rpm installation (elastic#22153)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Platforms Label for the Integrations - Platforms team v7.10.0 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@newly12 @elasticmachine @kaiyan-sheng @andresrc