Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21797 to 7.x: [Filebeat][okta] Fix okta pagination #21878

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 16, 2020

Cherry-pick of PR #21797 to 7.x branch. Original message:

What does this PR do?

  • Fixed header checking for the pagination used by okta
  • Add sanity check when initializing the date cursor
  • Advance cursor at every page
  • Store okta cursor

Why is it important?

Okta was failing to get pagination information correctly from headers

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

* Fix okta pagination

* Use cursor storage

(cherry picked from commit 80d4209)
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 16, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21878 opened]

  • Start Time: 2020-10-16T07:06:17.220+0000

  • Duration: 70 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 1944
Skipped 259
Total 2203

@marc-gr marc-gr requested a review from a team October 21, 2020 08:29
@marc-gr marc-gr merged commit 528d200 into elastic:7.x Oct 22, 2020
@marc-gr marc-gr deleted the backport_21797_7.x branch October 22, 2020 09:00
@zube zube bot removed the [zube]: Done label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants