Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diskio and memory bugs under windows #21992

Merged

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

Fixes some Windows bugs found under testing. We need to only call CalcIOStatistics under linux, and memory.share should be removed outside of agent, since it's a "null zero" metric under windows.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • pull down and build on Windows
  • On windows, make sure system/diskio works, and system.process.memory.share does not work.

@fearful-symmetry fearful-symmetry added bug needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.10.0 labels Oct 19, 2020
@fearful-symmetry fearful-symmetry requested a review from a team October 19, 2020 16:55
@fearful-symmetry fearful-symmetry self-assigned this Oct 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 19, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21992 opened]

  • Start Time: 2020-10-19T16:56:40.873+0000

  • Duration: 92 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 2245
Skipped 508
Total 2753

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on macbook and this PR fixed the error calculating iostat: not implemented out of linux problem I see for diskio metricset.

@fearful-symmetry fearful-symmetry merged commit 6955665 into elastic:master Oct 19, 2020
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Oct 19, 2020
@fearful-symmetry fearful-symmetry added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 19, 2020
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Oct 19, 2020
fearful-symmetry added a commit that referenced this pull request Oct 20, 2020
fearful-symmetry added a commit that referenced this pull request Oct 20, 2020
v1v added a commit to v1v/beats that referenced this pull request Oct 21, 2020
* upstream/master:
  feat: package aliases for snapshots (elastic#21960)
  [DOC] Add firewall as possible troubleshooting issue (elastic#21743)
  [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993)
  [Elastic Agent] Fix missing elastic_agent event data  (elastic#21994)
  Document auditbeat system process module config (elastic#21766)
  Update links (elastic#22012)
  dynamically find librpm (elastic#21936)
  Fix Istio docs (elastic#22019)
  [beats-tester][packaging] store packages in another location (elastic#21903)
  [Kubernetes] Remove redundant dockersock volume mount (elastic#22009)
  [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951)
  Azure storage metricset values not inside the metricset name (elastic#21845)
  fix diskio and memory bugs under windows (elastic#21992)
  Fix TestDockerStart flaky test (elastic#21681)
  filebeat: add SSL options to checkpoint module (elastic#19560)
  Stop storing stateless kubernetes keystores (elastic#21880)
  [Elastic Agent] Fix named pipe communication on Windows 7 (elastic#21931)
  [Elastic Agent] Fix index for Agent monitoring to to elastic_agent. (elastic#21932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Integrations Label for the Integrations team v7.10.0 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants