-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix diskio and memory bugs under windows #21992
Merged
fearful-symmetry
merged 1 commit into
elastic:master
from
fearful-symmetry:system-windows-fixes
Oct 19, 2020
Merged
Fix diskio and memory bugs under windows #21992
fearful-symmetry
merged 1 commit into
elastic:master
from
fearful-symmetry:system-windows-fixes
Oct 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
needs_backport
PR is waiting to be backported to other branches.
Team:Integrations
Label for the Integrations team
v7.10.0
labels
Oct 19, 2020
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 19, 2020
This was referenced Oct 19, 2020
kaiyan-sheng
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on macbook and this PR fixed the error calculating iostat: not implemented out of linux
problem I see for diskio metricset.
2 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Oct 19, 2020
(cherry picked from commit 6955665)
fearful-symmetry
added
v7.11.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Oct 19, 2020
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Oct 19, 2020
(cherry picked from commit 6955665)
2 tasks
fearful-symmetry
added a commit
that referenced
this pull request
Oct 20, 2020
fearful-symmetry
added a commit
that referenced
this pull request
Oct 20, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 21, 2020
* upstream/master: feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012) dynamically find librpm (elastic#21936) Fix Istio docs (elastic#22019) [beats-tester][packaging] store packages in another location (elastic#21903) [Kubernetes] Remove redundant dockersock volume mount (elastic#22009) [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951) Azure storage metricset values not inside the metricset name (elastic#21845) fix diskio and memory bugs under windows (elastic#21992) Fix TestDockerStart flaky test (elastic#21681) filebeat: add SSL options to checkpoint module (elastic#19560) Stop storing stateless kubernetes keystores (elastic#21880) [Elastic Agent] Fix named pipe communication on Windows 7 (elastic#21931) [Elastic Agent] Fix index for Agent monitoring to to elastic_agent. (elastic#21932)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes some Windows bugs found under testing. We need to only call
CalcIOStatistics
under linux, andmemory.share
should be removed outside of agent, since it's a "null zero" metric under windows.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
system/diskio
works, andsystem.process.memory.share
does not work.