Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22107 to 7.x: [libbeat] Add more disk queue unit tests and fix a size-check bug #22112

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

faec
Copy link
Contributor

@faec faec commented Oct 22, 2020

Cherry-pick of PR #22107 to 7.x branch. Original message:

What does this PR do?

Add more unit tests to the disk queue, and fix a bug they uncovered where data in an active write request was not counted against the total queue size when checking capacity.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Oct 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 22, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22112 opened]

  • Start Time: 2020-10-22T20:05:36.667+0000

  • Duration: 98 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 16341
Skipped 1365
Total 17706

@faec faec merged commit 296a70f into elastic:7.x Oct 23, 2020
@faec faec deleted the backport_22107_7.x branch October 23, 2020 11:26
@zube zube bot removed the [zube]: Done label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants