Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22107 to 7.10: [libbeat] Add more disk queue unit tests and fix a size-check bug #22113

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Cherry-pick #22107 to 7.10: [libbeat] Add more disk queue unit tests and fix a size-check bug #22113

merged 1 commit into from
Oct 23, 2020

Conversation

faec
Copy link
Contributor

@faec faec commented Oct 22, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22107 to 7.10 branch. Original message:

What does this PR do?

Add more unit tests to the disk queue, and fix a bug they uncovered where data in an active write request was not counted against the total queue size when checking capacity.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Oct 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 22, 2020
@elasticmachine
Copy link
Collaborator

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22113 opened]

  • Start Time: 2020-10-22T20:07:20.742+0000

  • Duration: 97 min 48 sec

Test stats 🧪

Test Results
Failed 1
Passed 16212
Skipped 1364
Total 17577

Test errors 1

Expand to view the tests failures

  • Name: Build&Test / libbeat-build / TestAddDockerMetadata – add_docker_metadata

    • Age: 1
    • Duration: 7.63
    • Error Details: Failed

Steps errors 1

Expand to view the steps failures

  • Name: libbeat-build - mage build test

    • Description: mage build test

    • Duration: 21 min 16 sec

    • Start Time: 2020-10-22T20:39:18.892+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-10-22T21:42:59.012Z]  runc:
[2020-10-22T21:42:59.012Z]   Version:          1.0.0-rc10
[2020-10-22T21:42:59.012Z]   GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
[2020-10-22T21:42:59.012Z]  docker-init:
[2020-10-22T21:42:59.012Z]   Version:          0.18.0
[2020-10-22T21:42:59.012Z]   GitCommit:        fec3683
[2020-10-22T21:43:13.794Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-10-22T21:43:13.822Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-10-22T21:43:13.897Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-22113-1/source/source.tgz
[2020-10-22T21:43:13.915Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-22113-1/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-22113/source.tgz
[2020-10-22T21:43:26.012Z] + tar --version
[2020-10-22T21:43:26.326Z] + tar -xpf source.tgz
[2020-10-22T21:43:38.903Z] + rm source.tgz
[2020-10-22T21:43:39.001Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats
[2020-10-22T21:43:39.030Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/libbeat-stress-tests-1603399165942
[2020-10-22T21:43:39.120Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/winlogbeat-crosscompile-1603399222722
[2020-10-22T21:43:39.205Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/auditbeat-crosscompile-1603399260858
[2020-10-22T21:43:39.293Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-dockerlogbeat-build-1603399304476
[2020-10-22T21:43:39.420Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-elastic-agent-build-1603399337033
[2020-10-22T21:43:39.507Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/journalbeat-unitTest-1603399344403
[2020-10-22T21:43:39.596Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-functionbeat-build-1603399418288
[2020-10-22T21:43:39.683Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/libbeat-crosscompile-1603399433075
[2020-10-22T21:43:39.773Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/packetbeat-build-1603399557952
[2020-10-22T21:43:39.863Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/metricbeat-unitTest-1603399652188
[2020-10-22T21:43:39.955Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/auditbeat-windows-windows-2019-1603399711931
[2020-10-22T21:43:40.044Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-elastic-agent-windows-windows-2019-1603399716336
[2020-10-22T21:43:40.128Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/metricbeat-crosscompile-1603399767056
[2020-10-22T21:43:40.213Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/generator-metricbeat-test-1603399771227
[2020-10-22T21:43:40.305Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/heartbeat-windows-windows-2019-1603399808486
[2020-10-22T21:43:40.392Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/generator-beat-test-1603399812429
[2020-10-22T21:43:40.482Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-auditbeat-windows-windows-2019-1603399861280
[2020-10-22T21:43:40.572Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/heartbeat-build-1603399864799
[2020-10-22T21:43:40.662Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/auditbeat-build-1603399888244
[2020-10-22T21:43:40.754Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-auditbeat-build-1603399907357
[2020-10-22T21:43:40.849Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/filebeat-windows-windows-2019-1603399907083
[2020-10-22T21:43:40.939Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/packetbeat-windows-windows-2019-1603399924303
[2020-10-22T21:43:41.029Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-winlogbeat-build-windows-2019-1603399944531
[2020-10-22T21:43:41.117Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/winlogbeat-windows-windows-2019-1603399956624
[2020-10-22T21:43:41.202Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-libbeat-build-1603399960308
[2020-10-22T21:43:41.289Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-functionbeat-windows-windows-2019-1603399984561
[2020-10-22T21:43:41.375Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-filebeat-windows-windows-2019-1603400014631
[2020-10-22T21:43:41.461Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/metricbeat-windows-windows-2019-1603400148717
[2020-10-22T21:43:41.545Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-metricbeat-windows-windows-2019-1603400226337
[2020-10-22T21:43:41.631Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/libbeat-build-1603400442435
[2020-10-22T21:43:41.719Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/filebeat-build-1603400740942
[2020-10-22T21:43:41.806Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-filebeat-build-1603401505065
[2020-10-22T21:43:41.899Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/metricbeat-goIntegTest-1603401534546
[2020-10-22T21:43:41.992Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/metricbeat-pythonIntegTest-1603401620517
[2020-10-22T21:43:42.079Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-metricbeat-build-1603402599165
[2020-10-22T21:43:42.480Z] + cat
[2020-10-22T21:43:42.480Z] + /usr/local/bin/runbld ./runbld-test-reports --job-name elastic+beats+pull-request
[2020-10-22T21:43:42.480Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-10-22T21:43:50.643Z] runbld>>> runbld started
[2020-10-22T21:43:50.643Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-10-22T21:43:51.585Z] runbld>>> The following profiles matched the job 'elastic+beats+pull-request' in order of occurrence in the config (last value wins).
[2020-10-22T21:43:51.585Z] runbld>>> Matches in the system config:
[2020-10-22T21:43:51.585Z] runbld>>> - Matched ^elastic\+beats
[2020-10-22T21:43:51.585Z] runbld>>> - Matched ^elastic\+beats\+pull-request
[2020-10-22T21:43:52.971Z] runbld>>> Debug logging enabled.
[2020-10-22T21:43:52.971Z] runbld>>> Storing result
[2020-10-22T21:43:53.234Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-10-22T21:43:53.234Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201022214352-C90C3FFC
[2020-10-22T21:43:53.234Z] runbld>>> Adding system facts.
[2020-10-22T21:43:54.627Z] runbld>>> Adding vcs info for the latest commit:  734adb2efeb1de636c8d43e7bd70c480b1536b1a
[2020-10-22T21:43:54.627Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-10-22T21:43:54.627Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-10-22T21:43:54.627Z] + echo 'Processing JUnit reports with runbld...'
[2020-10-22T21:43:54.627Z] Processing JUnit reports with runbld...
[2020-10-22T21:43:54.888Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-10-22T21:43:54.888Z] runbld>>> DURATION: 41ms
[2020-10-22T21:43:54.888Z] runbld>>> STDOUT: 40 bytes
[2020-10-22T21:43:54.888Z] runbld>>> STDERR: 49 bytes
[2020-10-22T21:43:54.888Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-10-22T21:43:54.889Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-22113
[2020-10-22T21:43:56.274Z] runbld>>> Storing build metadata: 
[2020-10-22T21:43:56.274Z] runbld>>> Adding test report.
[2020-10-22T21:43:56.274Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats
[2020-10-22T21:43:56.846Z] runbld>>> Found 122 test output files
[2020-10-22T21:43:58.233Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/metricbeat-goIntegTest-1603401534546/metricbeat/build/TEST-go-integration-windows.xml
[2020-10-22T21:43:58.233Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/metricbeat-goIntegTest-1603401534546/metricbeat/build/TEST-go-integration-graphite.xml
[2020-10-22T21:44:00.149Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-metricbeat-build-1603402599165/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-10-22T21:44:00.149Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-metricbeat-build-1603402599165/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-10-22T21:44:00.149Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-metricbeat-build-1603402599165/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-10-22T21:44:00.149Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-metricbeat-build-1603402599165/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-10-22T21:44:00.149Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22113/src/github.com/elastic/beats/x-pack-metricbeat-build-1603402599165/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-10-22T21:44:00.410Z] runbld>>> Test output logs contained: Errors: 0 Failures: 1 Tests: 17577 Skipped: 1083
[2020-10-22T21:44:00.671Z] runbld>>> Storing result
[2020-10-22T21:44:00.671Z] runbld>>> FAILURES: 1
[2020-10-22T21:44:01.246Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-10-22T21:44:01.246Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201022214352-C90C3FFC
[2020-10-22T21:44:01.246Z] runbld>>> Email notification disabled by environment variable.
[2020-10-22T21:44:01.246Z] runbld>>> Slack notification disabled by environment variable.
[2020-10-22T21:44:07.569Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats_PR-22113
[2020-10-22T21:44:07.630Z] [INFO] getVaultSecret: Getting secrets
[2020-10-22T21:44:07.695Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-10-22T21:44:09.738Z] + chmod 755 generate-build-data.sh
[2020-10-22T21:44:09.739Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22113/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22113/runs/1 FAILURE 5807586
[2020-10-22T21:44:09.739Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22113/runs/1/steps/?limit=10000 -o steps-info.json
[2020-10-22T21:44:13.851Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22113/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-10-22T21:44:15.400Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22113/runs/1/log/ -o pipeline-log.txt

@faec faec merged commit 22881dd into elastic:7.10 Oct 23, 2020
@zube zube bot removed the [zube]: Done label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

Assignees
No one assigned
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faec @elasticmachine @fearful-symmetry