Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22150 to 7.10: Move cloudfoundry tags with metadata to common metadata fields #22212

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Cherry-pick #22150 to 7.10: Move cloudfoundry tags with metadata to common metadata fields #22212

merged 1 commit into from
Oct 28, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 27, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22150 to 7.10 branch. Original message:

What does this PR do?

In some Cloud Foundry deployments, metadata is included in tags, move these tags to the common fields.

Why is it important?

Adding metadata with add_cloudfoundry_metadata implies querying the app metadata APIs, and storing the returned values in a local cache. This may be not needed in deployments that already include metadata the events from the firehose.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. (Move cloudfoundry tags with metadata to common metadata fields #22150 (comment))

Related issues

@jsoriano
Move cloudfoundry tags with metadata to common metadata fields (elast…
2f369fb 
…ic#22150)

In some Cloud Foundry deployments, metadata is included in tags,
move these tags to the common fields so add_cloudfoundry_metadata
is not needed for these cases.

(cherry picked from commit 7c461f8)
@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 27, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 27, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [jsoriano commented: jenkins run the tests please]

  • Start Time: 2020-10-28T10:16:26.702+0000

  • Duration: 72 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 4860
Skipped 354
Total 5214

@jsoriano
Copy link
Member Author

jenkins run the tests please

1 similar comment
@jsoriano
Copy link
Member Author

jenkins run the tests please

sayden
sayden approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that changelog entry must be added according to comment #22150 (comment)

@jsoriano jsoriano merged commit 5436cf3 into elastic:7.10 Oct 28, 2020
@zube zube bot removed the [zube]: Done label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoriano @elasticmachine @exekias @sayden