Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to 6.8: Use google storage to keep artifact (#21910)(#22220)(#22297) #22376

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Cherry-pick to 6.8: Use google storage to keep artifact (#21910)(#22220)(#22297) #22376

merged 3 commits into from
Nov 3, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 3, 2020 •
edited
Loading

Backports the following commits to 6.8:

@v1v v1v added automation backport ci Team:Automation Label for the Observability productivity team labels Nov 3, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 3, 2020
@v1v v1v changed the title Cherry-pick to 6.8: [CI] Use google storage to keep artifacts (#21910) Cherry-pick to 6.8: CI 2.0 improvements (#21910)(#22220)(#22297) Nov 3, 2020
@v1v v1v requested a review from a team November 3, 2020 11:02
@v1v v1v self-assigned this Nov 3, 2020
@v1v v1v changed the title Cherry-pick to 6.8: CI 2.0 improvements (#21910)(#22220)(#22297) Cherry-pick to 6.8: Use google storage to keep artifact (#21910)(#22220)(#22297) Nov 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 3, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22376 updated]

  • Start Time: 2020-11-03T11:02:16.003+0000

  • Duration: 31 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 3471
Skipped 130
Total 3601

Steps errors 2

Expand to view the steps failures

  • Name: Install Go/Mage/Python/Docker/Terraform 1.10.8

    • Description: .ci/scripts/install-tools.sh

    • Duration: 2 min 28 sec

    • Start Time: 2020-11-03T11:14:24.877+0000

    • log

  • Name: Install Go/Mage/Python/Docker/Terraform 1.10.8

    • Description: .ci/scripts/install-tools.sh

    • Duration: 2 min 22 sec

    • Start Time: 2020-11-03T11:14:34.520+0000

    • log

cachedout
cachedout reviewed Nov 3, 2020
View reviewed changes
Jenkinsfile
} catch(err) {
// Upload the generated files ONLY if the step failed. This will avoid any overhead with Google Storage
upload = true
error("Error '${err.toString()}'")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't the single quotes here break interpolation of the variable? I would have thought this would have been printed literally as ${err.toString()} but perhaps not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole string is in double quotes, so groovy interpolation happens before the cosmetic '

@v1v v1v merged commit 4366fca into elastic:6.8 Nov 3, 2020
@v1v v1v deleted the backport/6.8/pr-21910 branch November 3, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout left review comments

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@v1v v1v

Labels
automation backport ci Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @elasticmachine @cachedout @kuisathaverat