-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ephemeral containers in add_kubernetes_metadata #22439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Nov 4, 2020
Collaborator
Collaborator
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jsoriano
added
needs_backport
PR is waiting to be backported to other branches.
v7.11.0
labels
Nov 6, 2020
ChrsMark
reviewed
Nov 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ChrsMark
approved these changes
Nov 9, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Nov 9, 2020
…tic#22439) (cherry picked from commit 92b4e3d)
Merged
6 tasks
jsoriano
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Nov 9, 2020
jsoriano
added a commit
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for ephemeral containers in
add_kubernetes_metadata
.Why is it important?
For consistency with #22389, where support for ephemeral containers is added to autodiscover.
Checklist
I have made corresponding changes to the documentationCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues