Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit file states to system/service #22557

Merged

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

This PR adds the unit file state to system/service This tells you if the service is enabled or disabled, and what the vendor default is.

Why is it important?

This is an important bit of data that appears in systemctl status ...

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull down PR and build
  • run system/service on Linux, check to see if unit_file exists.

Related issues

@fearful-symmetry fearful-symmetry added enhancement Team:Integrations Label for the Integrations team labels Nov 11, 2020
@fearful-symmetry fearful-symmetry requested a review from a team November 11, 2020 21:18
@fearful-symmetry fearful-symmetry self-assigned this Nov 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 11, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2248
Skipped 508
Total 2756

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 11, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22557 updated]

  • Start Time: 2020-11-16T15:49:17.940+0000

  • Duration: 64 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 2248
Skipped 508
Total 2756

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2248
Skipped 508
Total 2756

@andresrc andresrc added Team:Services (Deprecated) Label for the former Integrations-Services team and removed Team:Integrations Label for the Integrations team labels Nov 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@fearful-symmetry fearful-symmetry merged commit d52ef47 into elastic:master Nov 16, 2020
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Nov 16, 2020
* add unit file states to system/service

* add changelog

(cherry picked from commit d52ef47)
fearful-symmetry added a commit that referenced this pull request Nov 18, 2020
* add unit file states to system/service

* add changelog

(cherry picked from commit d52ef47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants