Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22682 to 7.10: Fix index template loading when the new index is selected #22742

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Nov 24, 2020

Cherry-pick of PR #22682 to 7.10 branch. Original message:

What does this PR do?

This PR fixes the setup.template.type setting. When index were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.

Why is it important?

setup.template.type=index was broken. Now it is fixed.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

./filebeat setup --index-management -E setup.template.type=index

Related issues

Closes #22482

@kvch kvch added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Nov 24, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2020
)

This PR fixes the `setup.template.type` setting. When `index` were selected, Beats based the generated index on the legacy format, not on the component. This prevented Beats from loading the index.

`setup.template.type=index` was broken. Now it is fixed.

```
./filebeat setup --index-management -E setup.template.type=index
```

Closes elastic#22482

(cherry picked from commit 569268d)
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22742 updated]

  • Start Time: 2020-11-24T17:30:02.925+0000

  • Duration: 58 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 16342
Skipped 1377
Total 17719

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16342
Skipped 1377
Total 17719

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport seems correct

@kvch kvch merged commit d694315 into elastic:7.10 Nov 25, 2020
@zube zube bot removed the [zube]: Done label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants